FS#40087 - [abs] Should report an error when user tries `abs linux`

Attached to Project: Arch Linux
Opened by ... (spider007) - Friday, 25 April 2014, 09:59 GMT
Last edited by Dave Reisner (falconindy) - Saturday, 18 June 2016, 14:26 GMT
Task Type Feature Request
Category Arch Projects
Status Closed
Assigned To Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

abs can be invoked with a repository name as first argument. However; I just noticed someone using `abs linux` and not realising /var/abs/core/linux wasn't updated. I created a simple patch which prevents this. This patch allows

'*/linux', 'c*' and 'core' but not 'linux' as argument
   abs-verify-argument (0.5 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Saturday, 18 June 2016, 14:26 GMT
Reason for closing:  Won't fix
Additional comments about closing:  No developers care about abs and we generally want it to die.
Comment by Doug Newgard (Scimmia) - Saturday, 26 April 2014, 01:59 GMT
  • Field changed: Summary ([abs] Should report an error when user tries `abs linux` → {abs} Should report an error when user tries `abs linux`)
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Category (Packages: Extra → Arch Projects)
  • Task assigned to Dave Reisner (falconindy)
Orphan, looks like falconindy worked on it last. If you don't want it, Dave, reassign to mfm.
Comment by Dave Reisner (falconindy) - Saturday, 21 June 2014, 16:21 GMT
Your patch is buggy -- if invalid arguments are specified on the commandline, abs will still run. Doesn't really make sense, given the purpose of the bug report.

The attached patch takes a different route, but should accomplish what you want.
   0001-validate-arguments-to-be... (1 KiB)
Comment by ... (spider007) - Thursday, 26 June 2014, 18:41 GMT
Your updated patch looks fine and fixes the issue better

Loading...