The issue tracker has been moved https://gitlab.archlinux.org/archlinux/archiso/-/issues
FS#40049 - Incorrect "script=" parameter expansion in .automated_script.sh
Attached to Project:
Release Engineering
Opened by Alexander Vladimirov (idkfa) - Wednesday, 23 April 2014, 07:44 GMT
Last edited by Gerardo Exequiel Pozzi (djgera) - Friday, 25 April 2014, 14:45 GMT
Opened by Alexander Vladimirov (idkfa) - Wednesday, 23 April 2014, 07:44 GMT
Last edited by Gerardo Exequiel Pozzi (djgera) - Friday, 25 April 2014, 14:45 GMT
|
DetailsWhen .automated_script.sh parses "script=" kernel command line parameter it uses longest prefix substitution for variable expansion:
echo "${param##*=}" For HTTP urls containing GET request parameters this leads to incorrect expansion on "=" symbol boundary. Changing expansion to "${param#*=}" fixes this issue: $ param="script=http://domain.tld/path/script?id=1¶m=2" && echo "${param##*=}" 2 $ param="script=http://domain.tld/path/script?id=1¶m=2" && echo "${param#*=}" http://domain.tld/path/script?id=1¶m=2 |
This task depends upon
Closed by Gerardo Exequiel Pozzi (djgera)
Friday, 25 April 2014, 14:45 GMT
Reason for closing: Fixed
Additional comments about closing: Thanks. https://projects.archlinux.org/archiso.g it/commit/?id=96499e4fd7a908463e0bbd09e8 605e377eb933b1
Friday, 25 April 2014, 14:45 GMT
Reason for closing: Fixed
Additional comments about closing: Thanks. https://projects.archlinux.org/archiso.g it/commit/?id=96499e4fd7a908463e0bbd09e8 605e377eb933b1