FS#39692 - [msmtp] msmtp-gnome-tool.py script should be user executable

Attached to Project: Arch Linux
Opened by Christian Kampka (chris-) - Sunday, 30 March 2014, 16:40 GMT
Last edited by Eric Belanger (Snowman) - Wednesday, 02 April 2014, 20:31 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The msmtp package contains a script "msmtp-gnome-tool.py" in /usr/share/doc/msmtp/msmtp-gnome-tool/ that is used to manage msmtp passwords in gnome-keyring. As it stands, the script is installed with mods making it only executable as root, which is not very useful.

I'd like to propose to change the mods on the script to 755 during installation so that unprivileged users can use it. It might also be appropiate to install/link the script to /usr/bin.

Additional info:
* msmtp 1.4.32-1


Steps to reproduce:
As user, run "/usr/share/doc/msmtp/msmtp-gnome-tool/msmtp-gnome-tool.py"
This task depends upon

Closed by  Eric Belanger (Snowman)
Wednesday, 02 April 2014, 20:31 GMT
Reason for closing:  Won't implement
Comment by Jan de Groot (JGC) - Wednesday, 02 April 2014, 14:16 GMT
Files in /usr/share/doc are not supposed to be executable. My guess is that upstream intended this script as an example instead of a program that should be installed systemwide and executed by users.
Comment by Christian Kampka (chris-) - Wednesday, 02 April 2014, 14:33 GMT
I agree that that files /usr/share/doc should not be executable, that is why I suggested installing it into /usr/bin.
I disagree with you evaluation of upstream, after all, the release note states that "The new script msmtp-gnome-tool.py manages Gnome Keyring passwords for msmtp.". The changelog mentions something similar. There is no indication however that this script is not meant to be a useful working script.
Besides that, what does it matter whether the script is intended as an example or not? It is perfectly functional and useful, so why not treat it as such?
Comment by Eric Belanger (Snowman) - Wednesday, 02 April 2014, 20:31 GMT
As written in PKGBUILD:
# Installing example configs and scripts to /usr/share/doc/msmtp
# as they are not installed by default (Debian and Gentoo do it this way)

If you disagree, contact upstream.

Loading...