FS#39641 - [netctl] [patch] Fix killing of pppd when stopping mobile_ppp and pppoe profiles

Attached to Project: Arch Linux
Opened by Jesse Young (jlyo) - Wednesday, 26 March 2014, 22:17 GMT
Last edited by Jouke Witteveen (jouke) - Tuesday, 06 May 2014, 10:18 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Jouke Witteveen (jouke)
Architecture x86_64
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

netctl's mobile_ppp, and probably pppoe, doesn't correctly kill pppd. This is because pppd's pid file has the format "$pid\n$ifname\n". This patch uses only the first line of the pid file as the argument to kill.

Found in netctl version 1.6

Steps to reproduce:
netctl start $profile
netctl stop $profile

where $profile has a Connection=mobile_ppp

I looked at the pppoe connection as well; it seems to suffer the same bug. I'm attaching a patch for pppoe, however I have no such connection type, and I'm unable to test it.
This task depends upon

Closed by  Jouke Witteveen (jouke)
Tuesday, 06 May 2014, 10:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  75b7a

Loading...