Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#39612 - [go] go fmt isn't installed by default

Attached to Project: Community Packages
Opened by rtaertnaei iae (eiartniaern) - Monday, 24 March 2014, 17:56 GMT
Last edited by Alexander F. Rødseth (xyproto) - Tuesday, 25 March 2014, 18:50 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Alexander F. Rødseth (xyproto)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

go fmt isn't installed by default while cover, vet etc are. I would suggest that we just install all go tools by default.
This task depends upon

Closed by  Alexander F. Rødseth (xyproto)
Tuesday, 25 March 2014, 18:50 GMT
Reason for closing:  Works for me
Comment by Alexander F. Rødseth (xyproto) - Tuesday, 25 March 2014, 13:26 GMT
Hi, fully agree, thanks for reporting. Will add fmt. Some of the go tools seems less relevant, though (for instance the one that deals with oracle databases).
Comment by John Luebs (jkluebs) - Tuesday, 25 March 2014, 15:33 GMT
Is the change in the latest package actually correct? gofmt was not added to tools because it is still part of core go. gofmt should even work in the original 1.2.1-1 package (As either /usr/bin/gofmt or /usr/bin/go fmt). So I am curious what prompted the initial report.

I don't think go fmt is even part of the go.tools package, so that part of the PKGBUILD is just failing. (And 1.2.1-2 and 1.2.1-3 seem to be identical trees).

Finally, the rationale of which tools to include and not was more driven by upstream concerns. vet and cover are designed to be put in the $GOROOT, not the $GOPATH, but the other tools go to $GOPATH.
So go get code.google.com/p/go.tools/cmd/{oracle,ssadump} and similar installs in your $GOPATH, and so should not be included with this package. If you do go get code.google.com/p/go.tools/cmd/vet it will try to put it where this PKGBUILD puts it.

I just went through go.tools and I believe we have everything, er, covered (godoc, vet, and cover) for GOROOT tools!
Comment by Alexander F. Rødseth (xyproto) - Tuesday, 25 March 2014, 18:41 GMT
John Luebs, I agree! Thank you for the analyis.

rtaertnaei iae,
The current go package already includes /usr/bin/gofmt. What are the steps to reproduce the issue, if you think that go fmt is missing?
Comment by Alexander F. Rødseth (xyproto) - Tuesday, 25 March 2014, 18:50 GMT
Closing as "Works for me". Please re-open if "fmt" really is missing from the go package and include steps to reproduce the issue.

Loading...