FS#39235 - [argyllcms] incorrect udev rule

Attached to Project: Community Packages
Opened by Sven Karsten Greiner (SammysHP) - Saturday, 08 March 2014, 16:13 GMT
Last edited by Doug Newgard (Scimmia) - Sunday, 02 August 2015, 17:47 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Timothy Redaelli (tredaelli)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The PKGBUILD of argyllcms contains a patch that "comments out" a specific rule. This "comment" is responsible for the following warning:

systemd-udevd[156]: unknown key '#IMPORT{program}' in /usr/lib/udev/rules.d/55-Argyll.rules:88
systemd-udevd[156]: invalid rule '/usr/lib/udev/rules.d/55-Argyll.rules:88'

The systemd udev .rules parser does not allow comments starting in the middle of the line. This seems to be a known issue, but was not fixed during the last months. As this is a patch in Arch I think it's a valid bug for Arch.


Additional info:
* package version(s)
argyllcms 1.6.3-1
This task depends upon

Closed by  Doug Newgard (Scimmia)
Sunday, 02 August 2015, 17:47 GMT
Reason for closing:  No response
Comment by Sven Karsten Greiner (SammysHP) - Monday, 10 March 2014, 17:49 GMT
This does not really solve the issue. Actually, sed does nothing in the current situation.

See [1] for the original bug, that should be fixed with this patch. The rule from Argyll CMS uses an old (deprecated?) way for doing... (what should that rule actually do?!).

See [2] for a patch by Ubuntu.

It looks like the rule was fixed upstream by adding the TEST in front of it (I think it wasn't there in older releases). That's why the comment started in the middle of the line.

I suggest to remove the patch completely from the PKGBUILD as it is not necessary anymore (and does nothing except for adding a stupid comment why it might comment out this line).

[1] https://bbs.archlinux.org/viewtopic.php?id=155589
[2] http://launchpadlibrarian.net/148820819/argyll_1.4.0-8ubuntu4_1.4.0-8ubuntu5.diff.gz
Comment by Timothy Redaelli (tredaelli) - Tuesday, 11 March 2014, 10:23 GMT
Since we don't have /lib/udev/usb-db I think the correct way to do this is to change the
TEST=="/lib/udev/usb-db", IMPORT{program}="usb-db %p"
to
IMPORT{builtin}="hwdb --subsystem=usb"

What do you think?
Comment by Sven Karsten Greiner (SammysHP) - Tuesday, 11 March 2014, 10:39 GMT
This would match the Ubuntu patch. I think it is ok as long as it is not fixed in upstream.

Here a few references why this IMPORT was added:
http://www.freelists.org/post/argyllcms/Argylls-udev-rules
http://www.freelists.org/post/argyllcms/Adding-an-import-to-the-udev-rule

Sadly, Argyll CMS does not use any versioning system and only the latest version is provided.
Comment by Doug Newgard (Scimmia) - Monday, 06 July 2015, 21:20 GMT
Status with 1.7.0 (or 1.6.3-3)?

Loading...