Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#39055 - [polipo] sytemd startup script does not use /etc/polipo/config
Attached to Project:
Community Packages
Opened by Johnny Halfmoon (jhalfmoon) - Wednesday, 26 February 2014, 20:41 GMT
Last edited by Daniel Micay (thestinger) - Thursday, 10 April 2014, 18:36 GMT
Opened by Johnny Halfmoon (jhalfmoon) - Wednesday, 26 February 2014, 20:41 GMT
Last edited by Daniel Micay (thestinger) - Thursday, 10 April 2014, 18:36 GMT
|
DetailsDescription:
The systemd startup script for polipo currently disregards the config file /etc/polipo/conf : ExecStart=/usr/bin/polipo daemonise=true logFile="/var/log/polipo.log" One would expect polipo to be started as follows, by default: ExecStart=/usr/bin/polipo -c /etc/polipo/config Additional info: Version 1.0.4.1-10 |
This task depends upon
Closed by Daniel Micay (thestinger)
Thursday, 10 April 2014, 18:36 GMT
Reason for closing: Not a bug
Additional comments about closing: see my comment
Thursday, 10 April 2014, 18:36 GMT
Reason for closing: Not a bug
Additional comments about closing: see my comment
If you want to use a configuration file, you should put it in one of
the locations `/etc/polipo/config' or `~/.polipo'; you can also use
the `-c' flag to put it in a non-standard location. See the file
`config.sample' for an example.
So it *should* be reading it. If it's not, there's probably something wrong with your config file or there's an upstream bug.
The polipo.service file clearly has no reference to any config file.
And no, Arch does not install /etc/polipo/config by default. Maybe this is the whole problem, did you rename the sample file?
The fix to this is to have the polipo package install itself in a less complicated way, more "The Arch Way", like this:
- Make the polipo service point to the polipo config by default: ExecStart=/usr/bin/polipo -c /etc/polipo/config
- Have the polipo package install the example config to /etc/polipo/config instead of /etc/polipo/config.example
If users then wanted to alter the behaviour of polipo, they would only have to edit /etc/polipo/config.
That's alot simpler than the current setup, which requires doing this:
- rename the example config from /etc/polipo/config.example to /etc/polipo/config
- copy the polipo service file to to /etc/systemd/system/polipo.service
- edit /etc/systemd/system/polipo.service to make it use the /etc/polipo/config
https://projects.archlinux.org/svntogit/community.git/tree/trunk/polipo.service?h=packages/polipo
Have you looked at this file and do you understand what is happening in that file? This file is supplied by the Arch package, not by upstream.
Notice that this:
> That's alot simpler than the current setup, which requires doing this:
> - rename the example config from /etc/polipo/config.example to /etc/polipo/config
> - copy the polipo service file to to /etc/systemd/system/polipo.service
> - edit /etc/systemd/system/polipo.service to make it use the /etc/polipo/config
is wrong. All you have to do with the current setup is the first step, and that is how upstream recommends doing things.
Having said that: Having the logfile 'hard coded' into the service file still necessitates modifying the service file to be able to define an alternative log location. It still might be a good idea to have the logFile parameter defined in the config file and have it installed to /etc/polipo/config by default, which would also facilitate systemd user sessions as Doug points out.
In any case, I'm glad the situation is now cleared up.
I agree that having the log file defined on the command line isn't optimal, but neither is having a /etc/polipo/config file by default when upstream recommends against it. If it's one or the other, the latter is probably the better choice. That said, it appears that it will log to /var/log/polipo by default when run with "daemonise=true", instead of the provided /var/log/polipo.log. Would it be easier and more correct to just ditch the command line option and use the default unless the user overrides it with a config file?