Arch Linux

Is your system up-to-date? It's supposed to be already fixed.

I can confirm that it's still broken.

namcap shows me this on re-compilation:

0ad W: Referenced library 'libnvmath.so' is an uninstalled dependency
0ad W: Referenced library 'libnvimage.so' is an uninstalled dependency
0ad W: Referenced library 'libnvtt.so' is an uninstalled dependency
0ad W: Referenced library 'libmozjs185-ps-release.so.1.0' is an uninstalled dependency
0ad W: Referenced library 'libminiupnpc.so.9' is an uninstalled dependency
0ad W: Referenced library 'libnvcore.so' is an uninstalled dependency
0ad W: Dependency included and not needed ('binutils')
0ad W: Dependency curl included but already satisfied
0ad W: Dependency libogg included but already satisfied
0ad W: Dependency libpng included but already satisfied
0ad W: Dependency libxml2 included but already satisfied
0ad W: Dependency sdl included but already satisfied
0ad W: Dependency zlib included but already satisfied
0ad W: Dependency libgl included but already satisfied
0ad W: Dependency included and not needed ('0ad-data')
0ad W: Dependency included and not needed ('glu')
0ad W: Dependency included and not needed ('miniupnpc')
0ad W: Dependency included and not needed ('libsm')

I started a new build with --with-system-miniupnpc enabled to check if I can fix it for Manjaro Linux.

It just failed. Seems we have to look for a patch:

NetSession.cpp
../../../source/network/NetServer.cpp: In static member function 'static void* CNetServerWorker::SetupUPnP(void*)':
../../../source/network/NetServer.cpp:279:36: error: too few arguments to function 'int UPNP_GetSpecificPortMappingEntry(const char*, const char*, const char*, const char*, const char*, char*, char*, char*, char*, char*)'
NULL/*enabled*/, duration);
^
In file included from ../../../source/network/NetServer.cpp:38:0:
/usr/include/miniupnpc/upnpcommands.h:164:1: note: declared here
UPNP_GetSpecificPortMappingEntry(const char * controlURL,
^
network.make:166: recipe for target 'obj/network_Release/NetServer.o' failed
make[1]: *** [obj/network_Release/NetServer.o] Error 1

I discussed this with 0ad devs in IRC. miniupnpc version and API is hardcoded in libraries/source/miniupnpc/src/apiversions.txt and libraries/source/miniupnpc/src/CMakeLists.txt. For now, build here with "--without-miniupnpc", this only disables port-forwarding, hopefully a fix will be committed soon.

As Anke already mentioned. Here is her workaround for this issue: https://github.com/KaOSx/apps/commit/e9eaebaa82d5c5f5eede9aaa02b5df00d4c742e1
I'll do the same for Manjaro now.

Didn't Barthalion fix this for now?

I was trying to be too clever, I'll fix it correctly in a moment.

It would be great if you could drop me a line somewhere (e-mail or IRC) if port forwarding works in 0ad a15-4.