FS#38769 - {wiki} distinguish https links from the internal links
Attached to Project:
Arch Linux
Opened by Jakub Klinkovský (lahwaacz) - Sunday, 02 February 2014, 15:52 GMT
Last edited by Doug Newgard (Scimmia) - Saturday, 11 March 2017, 04:22 GMT
Opened by Jakub Klinkovský (lahwaacz) - Sunday, 02 February 2014, 15:52 GMT
Last edited by Doug Newgard (Scimmia) - Saturday, 11 March 2017, 04:22 GMT
|
Details
The "archlinux" skin for ArchWiki shows a little icon next
to the external links [1], but it is currently blocked for
https links [2]. It appears that it was blocked for some
reason [3], but aesthetically it is a bug because now the
https links look exactly the same as internal wiki links.
See also this related discussion on ArchWiki: [4]. [1]: https://projects.archlinux.org/vhosts/wiki.archlinux.org.git/tree/skins/archlinux/main.css#n147 [2]: https://projects.archlinux.org/vhosts/wiki.archlinux.org.git/tree/skins/archlinux/arch.css#n68 [3]: https://projects.archlinux.org/vhosts/wiki.archlinux.org.git/commit/skins/archlinux/archlinux.css?id=e8b7a08c663a0fb392a24c67ec1dea59057f480a [4]: https://wiki.archlinux.org/index.php/Help_talk:Style#Distinguish_fragment_identifier_interwiki_links.3F |
This task depends upon
Closed by Doug Newgard (Scimmia)
Saturday, 11 March 2017, 04:22 GMT
Reason for closing: None
Additional comments about closing: "Obsolete, the CSS is different now and the problem doesn't exist anymore."
Saturday, 11 March 2017, 04:22 GMT
Reason for closing: None
Additional comments about closing: "Obsolete, the CSS is different now and the problem doesn't exist anymore."
Internal links wouldn't get the icon anymore because their href starts with "/index.php" now, so the CSS rule doesn't apply, hence the patch could be applied. In fact, it is already applied with [1], which is the way we've found to override the CSS in the repo files (only admins can edit that wiki page); the other relevant pages are described in [2]. Of course it's easy to test any CSS fix with tools like Firebug, before actually applying them.
Because of this, I was thinking that maybe it could be a good idea to simplify everything by leaving the bare essential style rules (if any) in the skin in the repo, and move all the style rules to the files in [2], so that admins will be able to fix bugs without having to open a bug report and provide a patch, also relieving you of some of the maintenance workload. I'm saying this because we're discussing some other improvements to the style rules in e.g. [3] and [4], so we'd end up having to use the "local" sheets in any case.
I can provide a new patch for this migration if you want.
[1] https://wiki.archlinux.org/index.php/MediaWiki:Archlinux.css
[2] http://www.mediawiki.org/wiki/Manual:Interface/Stylesheets
[3] https://wiki.archlinux.org/index.php/MediaWiki_talk:Archlinux.css
[4] https://wiki.archlinux.org/index.php/Help_talk:Style#Visited_links_color