FS#38719 - [id3lib] man pages were created but not added?

Attached to Project: Arch Linux
Opened by rob.til.freedman (rtfreedman) - Wednesday, 29 January 2014, 23:25 GMT
Last edited by Guillaume ALAUX (galaux) - Thursday, 30 January 2014, 20:36 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Guillaume ALAUX (galaux)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The patch 20-create-manpages.patch does what it says. Shouldn't we add them to the package?

package() {
cd ${srcdir}/${pkgname}-${pkgver}
make DESTDIR="${pkgdir}" install

install -m755 -d ${pkgdir}/usr/share/man/man1
install -m644 -t ${pkgdir}/usr/share/man/man1 \
doc/man/id3cp.1 doc/man/id3tag.1 doc/man/id3convert.1 doc/man/id3info.1
}
This task depends upon

Closed by  Guillaume ALAUX (galaux)
Thursday, 30 January 2014, 20:36 GMT
Reason for closing:  Implemented
Additional comments about closing:  3.8.3-15
Comment by rob.til.freedman (rtfreedman) - Thursday, 30 January 2014, 00:18 GMT
Hm, there is a typo in id3convert.1 and id3cp.1
-1, --v2tag
should be
-2, --v2tag

Comment by Jan de Groot (JGC) - Thursday, 30 January 2014, 12:30 GMT
Also note that the variable changes done in the PKGBUILD breaks the build when building from paths containing spaces. Either add back the quotes or don't reference $srcdir (patch -Np1 -i ../patchfile instead of $srcdir/patchfile).
Comment by Guillaume ALAUX (galaux) - Thursday, 30 January 2014, 20:36 GMT
Man page typos fixed, man pages added to package and double-quotes added to PKGBUILD.

Loading...