FS#38534 - [laptop-mode-tools] does not properly start/stop by systemd

Attached to Project: Community Packages
Opened by camden linday (thenextdon13) - Wednesday, 15 January 2014, 19:18 GMT
Last edited by Lukas Jirkovsky (6xx) - Saturday, 25 January 2014, 11:43 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Lukas Jirkovsky (6xx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Description:
systemctl stop laptop-mode.service does not actually disable laptop-mode

It looks like systemd is trying to pass laptop-mode-tools the 'stop' and 'start' commands like this:
ExecStop=/usr/bin/laptop_mode init stop
ExecStop=/usr/bin/laptop_mode init auto

The author notes in #4 in this faq http://samwel.tk/laptop_mode/faq
"Note that the /usr/sbin/laptop_mode command does not support the "start" and "stop" commands anymore. These commands interfere with the low-battery detection code, and they default to "auto" for that reason."



Additional info:
* package version(s)
Version : 1.64-1
[dylan@zenbook ~]$ uname -a
Linux zenbook 3.12.6-1-iwlwifidebug #1 SMP PREEMPT Sun Dec 29 01:49:34 PST 2013 x86_64 GNU/Linux
[dylan@zenbook ~]$

* config and/or log files etc.
Default

Steps to reproduce:

Power plugged, laptop mode running
[dylan@zenbook ~]$ cat /proc/sys/vm/laptop_mode
0
[dylan@zenbook ~]$ sudo systemctl status laptop-mode.service
laptop-mode.service - Laptop Mode Tools
Loaded: loaded (/usr/lib/systemd/system/laptop-mode.service; enabled)
Active: active (exited) since Tue 2014-01-14 23:09:06 PST; 6s ago
Process: 19666 ExecStopPost=/bin/rm -f /var/run/laptop-mode-tools/enabled (code=exited, status=0/SUCCESS)
Process: 19104 ExecStop=/usr/bin/laptop_mode init stop (code=exited, status=0/SUCCESS)
Process: 19686 ExecStart=/usr/bin/laptop_mode init auto (code=exited, status=0/SUCCESS)
Main PID: 19686 (code=exited, status=0/SUCCESS)

Jan 14 23:09:06 zenbook systemd[1]: Starting Laptop Mode Tools...
Jan 14 23:09:06 zenbook systemd[1]: Started Laptop Mode Tools.
[dylan@zenbook ~]$ sudo iwconfig wlan0 | grep Management
Power Management:off



Stop laptop_mode
[dylan@zenbook ~]$ sudo systemctl stop laptop-mode.service
[dylan@zenbook ~]$ sudo systemctl status laptop-mode.service
laptop-mode.service - Laptop Mode Tools
Loaded: loaded (/usr/lib/systemd/system/laptop-mode.service; enabled)
Active: inactive (dead) since Tue 2014-01-14 23:11:52 PST; 1s ago
Process: 23538 ExecStopPost=/bin/rm -f /var/run/laptop-mode-tools/enabled (code=exited, status=0/SUCCESS)
Process: 22972 ExecStop=/usr/bin/laptop_mode init stop (code=exited, status=0/SUCCESS)
Process: 19686 ExecStart=/usr/bin/laptop_mode init auto (code=exited, status=0/SUCCESS)
Main PID: 19686 (code=exited, status=0/SUCCESS)

Jan 14 23:09:06 zenbook systemd[1]: Starting Laptop Mode Tools...
Jan 14 23:09:06 zenbook systemd[1]: Started Laptop Mode Tools.
Jan 14 23:11:52 zenbook systemd[1]: Stopping Laptop Mode Tools...
Jan 14 23:11:52 zenbook systemd[1]: Stopped Laptop Mode Tools.


Unplug power...

Wireless still being set into Power Management mode:
[dylan@zenbook ~]$ sudo iwconfig wlan0 | grep Management
Power Management:on
[dylan@zenbook ~]$

and laptop mode still showing as active
[dylan@zenbook ~]$ cat /proc/sys/vm/laptop_mode
2

Verify that laptop mode is supposed to be stopped:
[dylan@zenbook ~]$ sudo systemctl status laptop-mode.service
laptop-mode.service - Laptop Mode Tools
Loaded: loaded (/usr/lib/systemd/system/laptop-mode.service; enabled)
Active: inactive (dead) since Tue 2014-01-14 23:11:52 PST; 1min 35s ago
Process: 23538 ExecStopPost=/bin/rm -f /var/run/laptop-mode-tools/enabled (code=exited, status=0/SUCCESS)
Process: 22972 ExecStop=/usr/bin/laptop_mode init stop (code=exited, status=0/SUCCESS)
Process: 19686 ExecStart=/usr/bin/laptop_mode init auto (code=exited, status=0/SUCCESS)
Main PID: 19686 (code=exited, status=0/SUCCESS)

Jan 14 23:09:06 zenbook systemd[1]: Starting Laptop Mode Tools...
Jan 14 23:09:06 zenbook systemd[1]: Started Laptop Mode Tools.
Jan 14 23:11:52 zenbook systemd[1]: Stopping Laptop Mode Tools...
Jan 14 23:11:52 zenbook systemd[1]: Stopped Laptop Mode Tools.

Plug power back in...

Verify that wireless Power Management state changed back
[dylan@zenbook ~]$ sudo iwconfig wlan0 | grep Management
Power Management:off
[dylan@zenbook ~]$
This task depends upon

Closed by  Lukas Jirkovsky (6xx)
Saturday, 25 January 2014, 11:43 GMT
Reason for closing:  Upstream
Additional comments about closing:  Closing tasks for the recently dropped laptop-mode-tools.

This looks like an upstream bug, we don't do any changes to the systemd startup script.
Comment by Balló György (City-busz) - Wednesday, 15 January 2014, 19:59 GMT
The systemd unit file comes from upstream, so please report this problem to the upstream developer: http://www.samwel.tk/laptop_mode/
Comment by camden linday (thenextdon13) - Wednesday, 15 January 2014, 20:21 GMT
Interesting. I sent him an email and he noted that systemd was new and perhaps to file a bug with you guys. Will respond back to him again.
Comment by camden linday (thenextdon13) - Wednesday, 15 January 2014, 21:47 GMT
Interesting. I sent him an email and he noted that systemd was new and perhaps to file a bug with you guys. Will respond back to him again.

Loading...