FS#38368 - [pacman] PKGBUILD has unquoted strings (patch)

Attached to Project: Arch Linux
Opened by CalimeroTeknik (Calimero) - Friday, 03 January 2014, 17:19 GMT
Last edited by Dave Reisner (falconindy) - Friday, 03 January 2014, 17:32 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:

Pacman's PKGBUILD doesn't properly follow what seems like the proper quoting guidelines in the wiki.
At least that PKGBUILD should be an example to follow.
See attached patch.

However, it contains unquoted strings, which is bad. (remember bumblebee?)

Tests still fail when building in a path with spaces, after fixing the PKGBUILD, but this is relevant to pacman itself.


Steps to Reproduce:

Try to build pacman in, for instance, "/tmp/test folder/".
   pacman-PKGBUILD-pedantic.patch (0 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Friday, 03 January 2014, 17:32 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in SVN.
Comment by CalimeroTeknik (Calimero) - Friday, 03 January 2014, 17:20 GMT
Upload of the patch failed while submitting
   pacman-PKGBUILD-pedantic.patch (3.1 KiB)
Comment by Dave Reisner (falconindy) - Friday, 03 January 2014, 17:27 GMT
- ln -s pacman "$pkgdir/usr/share/bash-completion/completions/$f"
+ ln -s pacman "${pkgdir}/usr/share/bash-completion/completions/$f"

This, and every other change in the patch that braces variables, is garbage.

Loading...