FS#38353 - Reflector 2013.12.15.1-1 not working without rsync

Attached to Project: Community Packages
Opened by Henk Verhagen (henk) - Thursday, 02 January 2014, 10:24 GMT
Last edited by Xyne (Xyne) - Sunday, 05 January 2014, 18:24 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Xyne (Xyne)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:Trying to update mirrorlist with reflector 2013.12..15.1-1 resulted in error:
Exception in thread Thread-5:
Traceback (most recent call last):
File "/usr/lib/python3.3/threading.py", line 901, in _bootstrap_inner
self.run()
File "/usr/lib/python3.3/threading.py", line 858, in run
self._target(*self._args, **self._kwargs)
File "/usr/lib/python3.3/site-packages/Reflector.py", line 353, in worker
stderr=subprocess.DEVNULL
File "/usr/lib/python3.3/subprocess.py", line 542, in check_call
retcode = call(*popenargs, **kwargs)
File "/usr/lib/python3.3/subprocess.py", line 523, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.3/subprocess.py", line 824, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.3/subprocess.py", line 1448, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'rsync


Additional info:https://bbs.archlinux.org/viewtopic.php?id=175099
Installing rsync solved the problem.
* package version(s)
* config and/or log files etc.


Steps to reproduce:
This task depends upon

Closed by  Xyne (Xyne)
Sunday, 05 January 2014, 18:24 GMT
Reason for closing:  Fixed
Additional comments about closing:  reflector 2014-1
Comment by Karol Błażewicz (karol) - Thursday, 02 January 2014, 23:00 GMT
It works w/o rsync if you use '-p http' to specify the protocol.
Comment by Doug Newgard (Scimmia) - Friday, 03 January 2014, 05:24 GMT
So maybe it just needs to be an optdep instead of a hard dep?
Comment by Henk Verhagen (henk) - Friday, 03 January 2014, 09:20 GMT
The problem here is that previous versions worked without specifying a protocol. Given the situation as it is now
the wiki page should contain a warning or tip to install rsync if you don't want to specify a specific protocol.
And yes, it should be an optdep when installing reflector
Comment by Xyne (Xyne) - Sunday, 05 January 2014, 18:23 GMT
This should be fixed now. Sorry for the delay. Someone submitted a patch for rating rsync servers before the holidays, which I adapted and applied. After a few days on my server no bugs were reported so I pushed it to community. The bug only appears when rsync is not installed (and when not using the protocol option) so I missed it.

Without rsync it will silently fail now as it did before and move all rsync mirrors to the bottom of the rate-sorted list. I'll add rsync to the optional dependencies.

Loading...