FS#38027 - [libvirt-python] broken package because of too eager sed replacement

Attached to Project: Community Packages
Opened by Claudio (cb73) - Thursday, 05 December 2013, 17:40 GMT
Last edited by Sergej Pupykin (sergej) - Thursday, 05 December 2013, 21:14 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

This breaks libvirt packages which depend upon a working python library (virt-manager, cf. https://bugs.archlinux.org/task/37990?project=5&cat[0]=33&string=virt-manager)

Additional info:
* package version(s)
* config and/or log files etc.

Steps to reproduce:

Apply the prepare() phase of the PKGBUILD. Invoking the sed lines breaks generator.py which is part of libvirt-python:

"git diff generator.py"

-#!/usr/bin/python -u
+#!/usr/bin/python2 -u
#
# generate python wrappers from the XML API description
#
@@ -146,7 +146,7 @@ class docParser(xml.sax.handler.ContentHandler):
self.function_return, self.function_args,
self.function_file, self.function_module,
self.function_cond)
- elif self.function_file == "python":
+ elif self.function_file == "python2":
function(self.function, self.function_descr,
self.function_return, self.function_args,
self.function_file, self.function_module,
@@ -727,7 +727,7 @@ def print_function_wrapper(module, name, output, export, include):
export.write(" { (char *)\"%s\", libvirt_qemu_%s, METH_VARARGS, NULL },\n" %
(name, name))

- if file == "python":
+ if file == "python2":
# Those have been manually generated
if cond is not None and cond != "":
include.write("#endif\n")


To fix, replace the sed statements in PKGBUILD with an orderly patch, see this commit: http://libvirt.org/git/?p=libvirt-python.git;a=commit;h=9d9e2513c09e7ba7474c94455e5f82b3d00e6396
This task depends upon

Closed by  Sergej Pupykin (sergej)
Thursday, 05 December 2013, 21:14 GMT
Reason for closing:  Fixed

Loading...