Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#37852 - [lz4] Package development files
Attached to Project:
Community Packages
Opened by Mika Attila (SneakySnake) - Wednesday, 20 November 2013, 15:29 GMT
Last edited by Sébastien Luttringer (seblu) - Monday, 30 December 2013, 22:29 GMT
Opened by Mika Attila (SneakySnake) - Wednesday, 20 November 2013, 15:29 GMT
Last edited by Sébastien Luttringer (seblu) - Monday, 30 December 2013, 22:29 GMT
|
DetailsDescription:
The CMake build of lz4 allows building lz4 as a shared library, and the install target also packages the header files in addition to the library and the lz4 tool. Additional info: I am collaborating on a project, and the lead developer decided to use lz4 as an external library instead of putting the lz4 source files in the source tree. It would be handy if the lz4 package shipped the development files. |
This task depends upon
Closed by Sébastien Luttringer (seblu)
Monday, 30 December 2013, 22:29 GMT
Reason for closing: Upstream
Additional comments about closing: Bug opened upstream. Discussion should continue there.
Monday, 30 December 2013, 22:29 GMT
Reason for closing: Upstream
Additional comments about closing: Bug opened upstream. Discussion should continue there.
It doesn't install some of the files that the original package does. I'll leave it up to the package maintainer to tweak it as he sees fit.
EDIT: This PKGBUILD is outdated, see the one I submitted below
No need for the build dir, just build in $pkgname/cmake. Why make things more complicated than they need to be?
Doesn't install custom license. This is required with BSD licensed packages.
The executable will have a different name on x86_64 and i686.
I think the lz4 executable was redundant, anyway, so not building/installing that shouldn't be a problem.
Redundant? Not really... The lz4 executable has an interface more similar to tools like gzip, bzip2, and xz.
https://code.google.com/p/lz4/issues/detail?id=83&can=1
mkinitcpio will rely on it.
No reason for autotools, cmake fills that roll just fine.
<quote>
I don't exactly maintain the cmake file, because I don't know how it works.
...
I would prefer if possible to embed this capability directly into makefile. I don't know yet how to do it, but I guess it's possible to learn that part.
...
So here we are. I will try to have a look at it in the following days. My time availability is extremely low though, so I can't commit to get this out quickly.
</quote>
Please, send a patch upstream to have library, headers (and possibly man page) into the upstream Makefile.
I see no reason to force this downstream for now.
I created and submitted a patch upstream to fix various issues with the CMake build, and make it work as intended for building the Arch Linux lz4 package.
I also created an updated package, along with the patch. Now it should build the package as expected.
This is what I should have done originally, but I guess I was lazy. I apologize.
See the upstream issue here: https://code.google.com/p/lz4/issues/detail?can=2&start=0&num=100&q=&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary&groupby=&sort=&id=100
If you want library and development files be included, please provide an upstream patch to the official Makefile.
The cmake build is not supported by upstream, so, I will not switch to the cmake build system.
Instead, I will submit a liblz4 package to the AUR that only contains the development files.
Thank you for your time.
Adding further fragmentation and supporting an essentially unmaintained library is going to result in Bad Things™ down the road. Upstream accepted a patch which declares a stable interface (which is now his responsibility whether he likes it or not) without wanting to maintain it. It's brainless to rely on an interface which has no stability promise, and one which will break silently on upgrade.
Please don't support the cmake buildsys if upstream isn't interested in it.