FS#37655 - [graphicsmagick] Please move ghostscript to optdepends

Attached to Project: Arch Linux
Opened by Christopher Reimer (CReimer) - Tuesday, 05 November 2013, 19:09 GMT
Last edited by Gaetan Bisson (vesath) - Friday, 08 November 2013, 04:04 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Ronald van Haren (pressh)
Gaetan Bisson (vesath)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Please move ghostscript to optdepends as it is done with imagemagick.
This task depends upon

Closed by  Gaetan Bisson (vesath)
Friday, 08 November 2013, 04:04 GMT
Reason for closing:  Implemented
Additional comments about closing:  graphicsmagick-1.3.18-4 in [extra]
Comment by Eric Belanger (Snowman) - Tuesday, 05 November 2013, 22:24 GMT
Looking at the graphicmagic files, it doesn't use modules as imagemagick does. Unless there is a configure option to build modules ( --with-modules or one with another name), it looks like optdepends won't be possible. If modules is possible, then other depends might become optdepends too.

BTW, perllocal.pod and .packlist are removed automatically by makepkg, so the last lines of the package function can be removed.
Comment by Gaetan Bisson (vesath) - Wednesday, 06 November 2013, 07:11 GMT
Thanks for the tip about the extra files. I'll see what the --with-modules configure option can do for us.
Comment by Gaetan Bisson (vesath) - Wednesday, 06 November 2013, 08:03 GMT
If I just add '--with-modules' to the current PKGBUILD, without adding/removing any dependency, I get strange errors like "gm convert: No decode delegate for this image format (bla.jpg)."
The modules build probably needs a bit of work...
Comment by Eric Belanger (Snowman) - Wednesday, 06 November 2013, 16:43 GMT
Maybe a missing depends? Is it the same with other formats? You can always check the imagemagick PKGBUILD for ideas.
Comment by Gaetan Bisson (vesath) - Wednesday, 06 November 2013, 17:17 GMT
Eric: I do not believe it is a dependency issue: if I build without --with-modules I can do `gm convert bla.jpg bla.png` without a problem. If I build with --with-modules (without removing/adding any other package on my system) then this gives the error above. I'll have a look at imagemagick's PKGBUILD later, thanks.
Comment by Jan de Groot (JGC) - Wednesday, 06 November 2013, 17:26 GMT
When using modules, graphicsmagick uses libtool to open modules. Compiling with modules would need options=(libtool).
Comment by Gaetan Bisson (vesath) - Wednesday, 06 November 2013, 17:52 GMT
Ah. Of course, that makes sense. Thanks.
Comment by Eric Belanger (Snowman) - Wednesday, 06 November 2013, 18:19 GMT
That libtool issue hadn't crossed my mind but it needs the modules' libtool files. You can manually remove the library libtool files if you want (that what's done for imagemagick):
rm -f "${pkgdir}"/usr/lib/*.la

Comment by Jan de Groot (JGC) - Wednesday, 06 November 2013, 18:38 GMT
Looking at imagemagick's .la files:

dependency_libs=' /usr/lib/libMagickCore-6.Q16HDRI.la -llcms2 -llqr-1 -lglib-2.0 -lfontconfig -lfreetype -lXext -lX11 -lXt -llzma -lbz2 -lz -lltdl -lgomp -lOpenCL -lm'

The module .la files have dependencies on the .la files in /usr/lib, so if you delete them, the dependencies can't resolve anymore. Don't know if this is a problem for imagemagick/graphicsmagick, but for libsasl/cyrus-sasl it was.
Comment by Eric Belanger (Snowman) - Wednesday, 06 November 2013, 19:52 GMT
It's not an issue for imagemagick, the .la files in /usr/lib were removed several years ago without any problem.
Comment by Gaetan Bisson (vesath) - Friday, 08 November 2013, 04:03 GMT
I've decided to leave the libtool files under /usr/lib alone: they amount to a few kB only, and this keeps the package() function as simple as it currently is...

Loading...