Arch Linux

Please read this before reporting a bug:

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!

FS#36949 - [libffado] Invalid comments in /usr/lib/udev/rules.d/60-ffado.rules

Attached to Project: Arch Linux
Opened by Felix Yan (felixonmars) - Monday, 16 September 2013, 13:22 GMT
Last edited by Ray Rashif (schivmeister) - Thursday, 10 October 2013, 19:30 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Ray Rashif (schivmeister)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Systemd now only allows comments to start at beginning of line, not in the middle as 60-ffado.rules do.

With testing/systemd 207-1, there're errors generated every time when udev rules get loaded:

systemd-udevd[187]: invalid key/value pair in file /usr/lib/udev/rules.d/60-ffado.rules on line 3,starting at character 59 ('#')

Additional info:
* package version(s)
libffado 2.1.0-3
This task depends upon

Closed by  Ray Rashif (schivmeister)
Thursday, 10 October 2013, 19:30 GMT
Reason for closing:  Fixed
Comment by Dave Reisner (falconindy) - Wednesday, 18 September 2013, 15:17 GMT
Again, needs fixing in the rules parser. This is still valid.
Comment by Felix Yan (felixonmars) - Wednesday, 18 September 2013, 15:30 GMT
Well, I found "hint: comments can only start at beginning of line" in systemd code, but it's perfectly fine if it's going to be valid again :)
Comment by Dave Reisner (falconindy) - Wednesday, 18 September 2013, 15:35 GMT
Hrmm, I guess you're right -- the documentation never talks about mid-line comments. They've just been silently ignored until recently when I added this error reporting:

"Every line in the rules file contains at least one key-value pair. Except for empty lines or lines beginning with "#", which are ignored."

Fine by me if ffado just fixes this. Midline comments are actually quite a nightmare to deal with reliably.
Comment by Ray Rashif (schivmeister) - Wednesday, 25 September 2013, 19:55 GMT
These are non-intrusive errors, right? I'll just report this upstream, then.
Comment by Dave Reisner (falconindy) - Wednesday, 25 September 2013, 20:15 GMT
They're meaningless. The remainder of the rule is parsed correctly.
Comment by Ray Rashif (schivmeister) - Thursday, 10 October 2013, 17:27 GMT
Reported in Fedora, then upstream, and fix committed in upstream devel. [1] Will patch here until next release.