FS#36770 - [lxdm] do not set permissions in post_install/upgrade
Attached to Project:
Community Packages
Opened by Allan McRae (Allan) - Monday, 02 September 2013, 04:52 GMT
Last edited by Allan McRae (Allan) - Sunday, 08 September 2013, 22:29 GMT
Opened by Allan McRae (Allan) - Monday, 02 September 2013, 04:52 GMT
Last edited by Allan McRae (Allan) - Sunday, 08 September 2013, 22:29 GMT
|
Details
No idea whose bright idea this was!
In the lxdm post_install there is: chown -R 121:121 /var/lib/lxdm chgrp 121 /etc/lxdm/lxdm.conf chmod +r /etc/lxdm/lxdm.conf Do that in the PKGBUILD. That was pacman can track the permissions. The "chmod +r" is especially bad... Also, the post_upgrade runs post_install which does a usermod which reports "usermod: no changes". Then the same usermod command is in the post_upgrade but in a vercmp block to prevent it being run. And while I am ranting: - applying half the patches in prepare() and the rest in build() is strange. - there is no need for the "s:sbin:bin:" sed - the symlinks work fine. - the chmod on .pam_environment is unneeded - why is "/" used as a separator in the sed statement on lxdm.conf when replacing paths with "/" in them... - the echo statement has "\t"s in it. These should be actual tabs. |
This task depends upon
Closed by Allan McRae (Allan)
Sunday, 08 September 2013, 22:29 GMT
Reason for closing: Fixed
Additional comments about closing: 0.4.1-25
Sunday, 08 September 2013, 22:29 GMT
Reason for closing: Fixed
Additional comments about closing: 0.4.1-25
chown -R lxdm:lxdm /var/lib/lxdm > /dev/null
which results in pacman (4.2) outputting:
warning: directory ownership differs on /var/lib/lxdm/
filesystem: 121:121 package: 0:0
just "chown -R 121:121 $pkgdir/var/lib/lxdm" in the PKGBUILD