Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#36696 - [mupdf] Use system libraries as much as possible and don't set exec bit on header and doc files

Attached to Project: Community Packages
Opened by Leonid Isaev (lisaev) - Tuesday, 27 August 2013, 16:46 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Saturday, 31 August 2013, 09:13 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

There are 3 issues with community/mupdf-1.3-3:
(1) It doesn't use system shared libraries, instead the shipped libraries in
thirdparty/ are used. This is OK for openjpeg 2 (included in thirdparty/), but there is no reason to use e.g. thirdparty/curl which is older than core/curl (7.31 vs 7.32).
(2) The CURL_LIBS="" stanza in PKGBUILD's build() introduced in  FS#36567  is
doing absolutely nothing because curl is compiled-in statically. Even if
thirdparty/curl were removed, this variable wouldn't be picked up (see below).
(3) The header, doc and man files have permissions 0755, which is not really
nice.

Fix:

(1) I suggest to keep only thirdparty/openjpeg (to be dropped when [extra]
catches up) and jbig2dec (is it needed by anything besides mupdf?), and add a prepare() function to PKGBUILD

prepare() {
cd "$srcdir/$pkgname-$pkgver"-source
rm -vrf thirdparty/{curl,freetype,jpeg,zlib}/*
patch -Np1 -i $srcdir/mupdf-system-libcurl.patch
}

(2) The current Makefile is written in such a way, that curl support is
impossible unless thirdparty/curl is used. Thus Makefile has to be patched (see mupdf-system-libcurl.patch taken essentially unchanged from
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/mupdf/files/mupdf-9999-sys_curl.patch?view=markup ).

(3) Instead of running chmod on *.a files, why not run it on everything?

# Fix permissions on files
find $pkgdir/usr/include \
$pkgdir/usr/share \
$pkgdir/usr/lib -type f | xargs chmod -v 0644

HTH,
Leonid.
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Saturday, 31 August 2013, 09:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  mupdf 1.3-4
Comment by Bartłomiej Piotrowski (Barthalion) - Saturday, 31 August 2013, 09:04 GMT
Static build is only a temporarily workaround for the old openjpeg in repositories. I'll apply your fix for (3) and consider the rest.

Loading...