FS#36685 - [cinelerra-cv][PATCH] Fix call to avcodec_open2() for quicktime files

Attached to Project: Community Packages
Opened by Sung Pae (guns) - Tuesday, 27 August 2013, 03:51 GMT
Last edited by Ray Rashif (schivmeister) - Wednesday, 18 September 2013, 12:13 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ray Rashif (schivmeister)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Cinelerra exits with `no codec supplied to avcodec_open2()` (not
verbatim) when opening a Quicktime file. In my case, a DNxHD video file
in a mov container.

The reason for this is that the ffmpeg2.0.patch incorrectly translates
avcodec_open() -> avcodec_open2().

Simple patch follows this message inline, and may also be found at:

https://gist.github.com/guns/6349372/raw/cbbc0df36ca7c204b6e09dde7274580d3df7ec4c/ffmpeg2.0.patch.patch

Additional info:
* cinelerra-cv 1:2.2-17

Steps to reproduce:

Import and attempt to preview a *.mov file (perhaps with DNxHD video).


--- a/ffmpeg2.0.patch 2013-08-25 17:06:04.000000000 -0500
+++ b/ffmpeg2.0.patch 2013-08-26 22:33:52.606900207 -0500
@@ -75,7 +75,7 @@
}
- if(avcodec_open(context,
- ptr->decoder[i]) < 0)
-+ if(avcodec_open2(context,(ptr->decoder[i]) < 0,NULL))
++ if(avcodec_open2(context, ptr->decoder[i], NULL) < 0)
{
printf("quicktime_new_ffmpeg: avcodec_open failed.\n");
quicktime_delete_ffmpeg(ptr);
This task depends upon

Closed by  Ray Rashif (schivmeister)
Wednesday, 18 September 2013, 12:13 GMT
Reason for closing:  Fixed
Comment by Sung Pae (guns) - Tuesday, 27 August 2013, 03:59 GMT
Correction: Cinelerra does not _exit_ when opening a quicktime file; it
simply fails to open it.
Comment by Ray Rashif (schivmeister) - Sunday, 15 September 2013, 17:19 GMT
I have confirmed this and have applied the patch despite the lack of some official acknowledgement (since this affects runtime functionality). Please test -17 in testing.
Comment by Sung Pae (guns) - Wednesday, 18 September 2013, 00:21 GMT
I can confirm that 1:2.2-18 in testing fixes this issue.

Thank you!

Loading...