FS#36209 - [tigervnc] Add patch to fix libvnc.so crash

Attached to Project: Community Packages
Opened by U (Gusar) - Saturday, 20 July 2013, 11:23 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 22 July 2013, 13:25 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When using the libvnc.so module, X crashes as soon as you press a keyboard key. Fedora has a fix: http://pkgs.fedoraproject.org/cgit/tigervnc.git/commit/?id=cde0eb1edf1996e642070c8d61cfbc4ed5bad62e

Also, the gethomedir patch that was removed with the update to 1.3 is still needed AFAIK, at least Fedora still uses it. This patch also affects the libvnc.so module.

Then there's a patch that's not needed anymore :). xserver114.patch is part of the tigervnc source, we don't need to ship our own version.

Now we come to dependencies. It's not necessary to explicitly list libxcursor, libxft and libxinerama, they're dependencies of fltk and will be pulled through that. And imagemagick+librsvg are not makedepends anymore, they were needed to convert svg icons into png, but the 1.3 release already contains pre-generated png icons.

The attached PKGBUILD contains all these changes.
   gethomedir.patch (0.8 KiB)
   getmaster.patch (3.3 KiB)
   PKGBUILD (2.7 KiB)
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 22 July 2013, 13:25 GMT
Reason for closing:  Fixed
Comment by U (Gusar) - Saturday, 20 July 2013, 11:29 GMT
More cleanups to the PKGBUILD:

There's no internal fltk anymore, so don't pass that option to cmake. Also, with the pre-generated png icons it's no longer necessary to call make in the media dir and then install the icons manually in package(), the build system takes care of it automatically.
   PKGBUILD (2.5 KiB)

Loading...