Arch Linux

This bit me again today. Any thoughts, concerns?

Here's an updated PKGBUILD, if that's useful. The zprofile source should probably be renamed though.

# $Id: PKGBUILD 187080 2013-06-03 11:17:13Z allan $
# Maintainer: Pierre Schmitz <pierre@archlinux.de>

pkgname=zsh
pkgver=5.0.2
pkgrel=3
pkgdesc='A very advanced and programmable command interpreter (shell) for UNIX'
arch=('i686' 'x86_64')
url='http://www.zsh.org/'
license=('custom')
depends=('pcre' 'libcap' 'gdbm')
backup=('etc/zsh/zshenv')
install=zsh.install
source=("http://downloads.sourceforge.net/${pkgname}/${pkgname}-${pkgver}.tar.bz2"
'zprofile')
md5sums=('b8f2ad691acf58b3252225746480dcad'
'24a9335edf77252a7b5f52e079f7aef7')

build() {
cd "${srcdir}/${pkgname}-${pkgver}"

# Set correct keymap path
sed -i 's#/usr/share/keymaps#/usr/share/kbd/keymaps#g' Completion/Unix/Command/_loadkeys

# Remove unneeded and conflicting completion scripts
rm -rf Completion/{AIX,BSD,Cygwin,Darwin,Debian,Mandriva,openSUSE,Redhat,Solaris}
rm -f Completion/Linux/Command/_{pkgtool,rpmbuild,yast}
rm -f Completion/Unix/Command/_osc

./configure --prefix=/usr \
--enable-etcdir=/etc/zsh \
--enable-zshenv=/etc/zsh/zshenv \
--enable-zlogin=/etc/zsh/zlogin \
--enable-zlogout=/etc/zsh/zlogout \
--enable-zprofile=/etc/zsh/zprofile \
--enable-zshrc=/etc/zsh/zshrc \
--enable-maildir-support \
--with-term-lib='ncursesw' \
--enable-multibyte \
--enable-function-subdirs \
--enable-fndir=/usr/share/zsh/functions \
--enable-scriptdir=/usr/share/zsh/scripts \
--with-tcsetpgrp \
--enable-pcre \
--enable-cap \
--enable-zsh-secure-free
make
}

check() {
cd "${srcdir}/${pkgname}-${pkgver}"
HOME="${srcdir}" make check
}

package() {
cd "${srcdir}/${pkgname}-${pkgver}"
make DESTDIR="${pkgdir}/" install
install -D -m644 "${srcdir}/zprofile" "${pkgdir}/etc/zsh/zshenv"
install -D -m644 LICENCE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
}

This seems a recurring issue:
https://bugs.archlinux.org/task/24953 - June 2011
https://bugs.archlinux.org/task/31873 - October 2012

Is there some reason why we don't implement this as upstream intended? It is frustrating to have to use a work around to achieve what should be default behaviour.

The problem is that /etc/profile should only be sourced by login shells as its done by bash. zshenv would also be used by non-login shells.

Hmm. I can't think of a good solution, if that's a requirement. Mr. Ryan, I'm curious, what do you gather is intended by upstream?

I'm fairly sure I need/want /etc/profile sourced, just not from zprofile. If it can't be sourced in zshenv (for bash compatibility?), I'm at a loss as to where to do it.

The problem is probably in /etc/profile which does more than setting PATHs. It seems other Distros like Debian or Fedora use it this way as well. I have also seen warnigs about using more complex stuff inside zshenv.

It's the modifying of PATHs that's the exact issue though, since it occurs before ~/.zshenv where a user is meant to setup their own PATH.

Perhaps, if it's intended that PATHs be mucked with in a *profile file, then I should put my own path overrides in ~/.zprofile and not ~/.zshenv ?

s long as our global /etc/profile is some kind of mix between things that should go into zshenv and zprofile I suggest to set your PATH in zshrc. But still, it's not a big deal; have a look at pacman.conf's NoExtract or NoUpgrade options if you like to keep your own /etc/zprofile.

Thanks Pierre: I've gone with noextract...

Yes, thanks. That sounds like the option I'll go with as well.

A final question, if I may Pierre.

Zsh ships without an /etc/zsh/zprofile and Debian with an empty one: why do we create one rather than using the /etc/zsh/zshenv that ships from upstream (albeit with the line inserted to source /etc/profile)?

I am probably just being dense, but the solution that Patrick and I use, to copy /etc/zsh/zprofile to /etc/zsh/zshenv seems closer to upstream than the current approach. Our /etc/profile, FWIW, only differs from debian's in unsetting the man path and termcap (and sourcing bash.bashrc).

Any light you can shed on this would be helpful. Thanks.

Gentoo "resolved" this a while ago: https://bugs.gentoo.org/show_bug.cgi?id=19924#c50
Perhaps it should be taken upstream, since most systems shipping zsh have an issue with this (even OS X does).

@jasonwryan: if we don't ship zprofile, some PATH and vars wont get set and that will break applications. E.g. locale wont get set and Perl wont work. Upstream does not ship any default config. And to summarize: sourcing /etc/profile in zshenv is not correct and not useful.