FS#35930 - [cairo] 1.12.14 improperly formed PKGBUILD
Attached to Project:
Arch Linux
Opened by Garry Roseman (sitquietly) - Tuesday, 25 June 2013, 17:32 GMT
Last edited by Andreas Radke (AndyRTR) - Tuesday, 25 June 2013, 19:58 GMT
Opened by Garry Roseman (sitquietly) - Tuesday, 25 June 2013, 17:32 GMT
Last edited by Andreas Radke (AndyRTR) - Tuesday, 25 June 2013, 19:58 GMT
|
Details
Description: cairo is not a split package and has only a
simple package()
function in its PKGBUILD. The depends=() line should be in the normal location in the head of the file as described in the Arch Wiki entry for PKGBUILD and as is uniform practice. At present the depends line for the cairo PKGBUILD is inside the package() function. It looks like this is an accident after some editing; the depends line in the normal location was commented (in preparation for splitting?). I notice this because I use an awk script to parse all PKGBUILDs and have to assume some reasonable standard syntax for the file. There may be two schools of thought here: PKGBUILD is a declarative file that happens to also be a valid bash script, and PKGBUILD is just a bash script and anything that bash accepts is ok. I raise this as a bug because the "it's just a bash script" approach will make it difficult in the long run to develop good ancilliary tools for processing the Arch "database" of packaging definitions. I hope that the authors agree with me and will continue to keep PKGBUILDs "clean and tidy" and as declarative as possible. |
This task depends upon
Closed by Andreas Radke (AndyRTR)
Tuesday, 25 June 2013, 19:58 GMT
Reason for closing: Fixed
Additional comments about closing: fix commited to trunk
Tuesday, 25 June 2013, 19:58 GMT
Reason for closing: Fixed
Additional comments about closing: fix commited to trunk