FS#35728 - [amule] Fix installation issue (followup for FS#35708)

Attached to Project: Arch Linux
Opened by Anatol Pomozov (anatolik) - Sunday, 09 June 2013, 01:00 GMT
Last edited by Giovanni Scafora (giovanni) - Sunday, 27 October 2013, 16:23 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Giovanni Scafora (giovanni)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Use -d flag for useradd instead of -b

Additional changes:
- do not remove account on package remove. I saw that some packages do this. Feel free to change it (i.e. remove account and probably remove account home dir).
- do not change config files if they already exist.

Tested:
remove package, install it
remove package and home dir, install it
install package twice in a row
(application/x-gzip)    amule-10803-3.src.tar.gz (1.8 KiB)
This task depends upon

Closed by  Giovanni Scafora (giovanni)
Sunday, 27 October 2013, 16:23 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 10808-2
Comment by Anatol Pomozov (anatolik) - Sunday, 09 June 2013, 15:09 GMT
Update for previous patch:
- move 'systemctl stop amuled' from post_remove() to pre_remove() function.
(application/x-gzip)    amule-10803-3.src.tar.gz (1.8 KiB)
Comment by Jan de Groot (JGC) - Monday, 10 June 2013, 09:11 GMT
Stopping and starting services has never been part of our install script and is the task of the system administrator.
Comment by Anatol Pomozov (anatolik) - Tuesday, 11 June 2013, 00:51 GMT
If one tries to remove a package with service running it will not be possible to stop the service correctly. What is the standard practice here? Just ignore this issue? If so then pre_remove() function can be removed from my patch.
Comment by Anatol Pomozov (anatolik) - Thursday, 13 June 2013, 02:44 GMT
Update: removed pre_remove()
(application/x-gzip)    amule-10803-3.src.tar.gz (1.8 KiB)
Comment by Anatol Pomozov (anatolik) - Wednesday, 26 June 2013, 04:21 GMT
Hi, Giovanni.

What do you think about this improvement? Do you have time to review it? Feel free to assign future bugs on amule systemd to me.

FYI: I also updated wiki page to systemd some time ago https://wiki.archlinux.org/index.php/AMule
Comment by Anatol Pomozov (anatolik) - Saturday, 13 July 2013, 21:38 GMT
Actually I realized that generating additional config file on installation is not the 'Arch way'. It is better to keep post-install simpler and leave configuration to the user. Note that amule GUI does not need any configs - the configs are only for amuled/amuleweb. If user needs amuled/amuleweb then he can go to the wiki where configuration steps are described.
(application/x-gzip)    amule-10803-4.src.tar.gz (1.6 KiB)
Comment by fabio (fabioamd) - Saturday, 26 October 2013, 16:15 GMT
Hi, I have amule 10803-1 installed, I don't have the systemd amuled file on my system so when I try to start amuled by systemctl I get an error (file not found).
How can I install the support for starting amuled with systemd? I just need to extract the file from that tar (amule-10803-4.src.tar.gz) and copy to /etc/systemd/system?
Or doing that will keep this file on my system when I remove amule? I can also try to remove and reinstall amule?

I noticed that the .service file aren't in the package, maybe are generated after the install? I have amule installed from many versions, and I remember that previously the package was an svn version before getting stable, certainly first of arch systemd introduction.
Comment by Anatol Pomozov (anatolik) - Saturday, 26 October 2013, 16:59 GMT
amuled used to have the systemd support, but it was reverted because of a bug. I (hopefully) fixed the bug and filed this ticket. Unfortunately owner of the package ignores this improvement :(

IMHO amule should be dropped to AUR - it has higher chance of proper support there.
Comment by Giovanni Scafora (giovanni) - Sunday, 27 October 2013, 14:19 GMT
Please, try amule-10808-2 now in [extra] and let me know, so I can finally close this bug report.
Comment by fabio (fabioamd) - Sunday, 27 October 2013, 16:16 GMT
After some try I didn't made it work, the process start with systemctl and it says that was active but I cannot find it with ps -A.

But was modifying the file /lib/systemd/system/amuled.service in the line "user", setting it to my username that I worked, and now I can connect with amuleGUI.

I think we just need to modify the wiki and we can close this bug.

Loading...