FS#35652 - [devtools] flags not always passed to makepkg

Attached to Project: Arch Linux
Opened by Allan McRae (Allan) - Wednesday, 05 June 2013, 05:53 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 21 August 2019, 04:49 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Pierre Schmitz (Pierre)
Dave Reisner (falconindy)
Eli Schwartz (eschwartz)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

With makechrootpkg downloading the sources with makepkg in one step and then running makepkg in another, we can no longer skip integrity checks:

> makechrootpkg64 -c -r /home/arch/chroot/testing-x86_64/ -- --skipinteg
==> Creating clean working copy [allan]...done
==> Making package: automake 1.13.2-1 (Wed Jun 5 15:51:30 EST 2013)
==> Retrieving sources...
-> Found automake-1.13.2.tar.xz
-> Found automake-1.13.2.tar.xz.sig
==> Validating source files with md5sums...
automake-1.13.2.tar.xz ... FAILED
automake-1.13.2.tar.xz.sig ... Skipped
==> ERROR: One or more files did not pass the validity check!
==> ERROR: Could not download sources.
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 21 August 2019, 04:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://git.archlinux.org/devtools.git/c ommit/?id=5fcd90a212d332fa2900ba4b1a1c12 e2ab55ea44
Comment by Alad Wenter (Alad) - Wednesday, 20 July 2016, 11:50 GMT
At first glance, the only way seems to expand the parser for arguments after --:

for arg in "${@:OPTIND}"; do
case ${arg%%=*} in
-*R*|--repackage)
repack=true
break 2
;;
esac
done

to any options that are applicable to --verifysource, in particular skipinteg/skipchecksums/skippgpcheck.

Loading...