FS#35633 - ddclient : systemd service ignores/overrides some configuration file parameters

Attached to Project: Community Packages
Opened by skai (skai) - Tuesday, 04 June 2013, 07:18 GMT
Last edited by Jonathan Steel (jsteel) - Wednesday, 05 June 2013, 19:53 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jonathan Steel (jsteel)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

in file :

/usr/lib/systemd/system/ddclient.service

the start command includes some options that overrides the configuration file parameters : '-daemon 300 -syslog' :

ExecStart=/usr/sbin/ddclient -daemon 300 -syslog -pid /run/ddclient.pid

doing this overrides the options set in /etc/ddclient/ddclient.conf

Simply removing '-daemon 300 -syslog' from ExecStart will work.




Additional info:
* package version(s) : 3.8.1.6
* config and/or log files etc.


Steps to reproduce:

just install and run.
This task depends upon

Closed by  Jonathan Steel (jsteel)
Wednesday, 05 June 2013, 19:53 GMT
Reason for closing:  Fixed
Additional comments about closing:  3.8.1-8
Comment by Jonathan Steel (jsteel) - Tuesday, 04 June 2013, 16:24 GMT
Yes, the same (default) options are set and read from /etc/ddclient/ddclient.conf so not sure why they are specified in the service file as well.

I think "-pid /run/ddclient.pid" can be removed as well, is there any reason you did not mention this?

Thanks
Comment by skai (skai) - Wednesday, 05 June 2013, 16:02 GMT
I did not mention the "-pid" ... because I didn't know and didn't test if it was useful or not :-)

I have some memories of problems that may occur when systmed is expecting a pid file somewhere,
and it is created elsewhere.
So... sounds a good idea to override the configuration file in this case.

But this needs tests, I was too lazy for this, and don't know systemd enough.
Comment by Jonathan Steel (jsteel) - Wednesday, 05 June 2013, 19:08 GMT
I'm in two minds, but as it's set the same in the default config it's most likely not going to make any difference anyway.

Loading...