FS#35583 - [Flyspray] Cannot remove votes (possible theme problem)

Attached to Project: Arch Linux
Opened by Dario Giovannetti (kynikos) - Saturday, 01 June 2013, 09:02 GMT
Last edited by Dan McGee (toofishes) - Monday, 03 June 2013, 13:45 GMT
Task Type Bug Report
Category Web Sites
Status Closed
Assigned To Jan de Groot (JGC)
Pierre Schmitz (Pierre)
Dan McGee (toofishes)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

I've noticed I can't remove my votes from the tasks that I voted on this bug tracker.

Removing votes should be enabled since Flyspray 0.9.9.7, which is the version we're using: https://bugs.flyspray.org/task/1661 , http://flyspray.org/changelog and https://projects.archlinux.org/vhosts/bugs.archlinux.org.git/commit/?id=ef4e76048105717c16e20fda446828503f3e21c5

After a quick investigation I've noticed that there's a difference between https://projects.archlinux.org/vhosts/bugs.archlinux.org.git/tree/templates/details.view.tpl and https://projects.archlinux.org/vhosts/bugs.archlinux.org.git/tree/themes/ArchLinux/details.view.tpl
The other two themes installed (Bluey and CleanFS) don't seem to have a details.view.tpl file

If somebody else can confirm this bug, I hope the info above will be helpful for fixing it.
This task depends upon

Closed by  Dan McGee (toofishes)
Monday, 03 June 2013, 13:45 GMT
Reason for closing:  Fixed
Comment by Allan McRae (Allan) - Saturday, 01 June 2013, 13:58 GMT
It is not as if anyone pays attention to votes anyway...
Comment by Dan McGee (toofishes) - Saturday, 01 June 2013, 14:13 GMT
FYI: I maintain the main website, not all these other sites with issues that are getting assigned to me. I have no intention in fixing this. We really need someone to take the lead and get us to a bug tracking system someone wants to actually maintain.

And Allan's point is well taken, this is absolutely non-essential to our developer workflow, so no need to fix it.
Comment by Dario Giovannetti (kynikos) - Saturday, 01 June 2013, 14:34 GMT
Is there anyone with a locally installed copy of our bug tracker who can test this patch?

It just removes themes/ArchLinux/details.view.tpl which is IMHO needlessly overriding templates/details.view.tpl (the only difference between the two files is just the lack of the link for removing votes and another link for a "dependency graph" feature).
   0001-Delete-themes-ArchLinux-... (14.5 KiB)
Comment by Dan McGee (toofishes) - Saturday, 01 June 2013, 14:37 GMT
I think we removed the dependency graph link because it doesn't work. The omission of the vote removal link was likely unintentional.
Comment by Dario Giovannetti (kynikos) - Saturday, 01 June 2013, 14:52 GMT
I see, in that case this patch should restore only the link for removing votes.

This is what happened to the main template with the upgrade to 0.9.9.7: https://projects.archlinux.org/vhosts/bugs.archlinux.org.git/diff/templates/details.view.tpl?id=ef4e76048105717c16e20fda446828503f3e21c5
Very likely the overriding file in the theme was forgotten, thus not being updated in accordance with the new version.

If we have an official bugtracker upgrade procedure, probably we should add there a reminder to update details.view.tpl and header.tpl in the ArchLinux theme.
   0001-Update-themes-ArchLinux-... (1.2 KiB)
Comment by Dan McGee (toofishes) - Monday, 03 June 2013, 13:45 GMT
Fixed. https://projects.archlinux.org/vhosts/bugs.archlinux.org.git/commit/?id=7f49165e73b89c8ddee2f85a23d8506bc909e3fc was basically your patch (newline ending issues, so I just did it manually), but more important was https://projects.archlinux.org/vhosts/bugs.archlinux.org.git/commit/?id=2c833a313ddafeea777afd8c6f4178770920057d.

Loading...