FS#35515 - Always install unchanged backup files

Attached to Project: Pacman
Opened by Allan McRae (Allan) - Tuesday, 28 May 2013, 04:05 GMT
Last edited by Allan McRae (Allan) - Sunday, 21 July 2013, 06:23 GMT
Task Type Bug Report
Category Backend/Core
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 4.1.1
Due in Version 4.2.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

If the file on the filesystem and the backup file to be installed have the same checksum, we skip their installation. That results in a whole heap of modification time mismatches for files in backup arrays with -Qkk. e.g.

warning: util-linux: /etc/pam.d/chfn (Modification time mismatch)
warning: util-linux: /etc/pam.d/chsh (Modification time mismatch)

Always installing these files would have little overhead and remove this issue.
This task depends upon

Closed by  Allan McRae (Allan)
Sunday, 21 July 2013, 06:23 GMT
Reason for closing:  Fixed
Additional comments about closing:  git commit d7d4f47d
Comment by Allan McRae (Allan) - Tuesday, 28 May 2013, 04:08 GMT
Would remove a lot of the noise with backup files in -Qkk, but  FS#34739  would still need addressed.
Comment by Patrick Steinhardt (pks) - Tuesday, 04 June 2013, 08:11 GMT
The attached patch uses the utime function to set access and modification time of backup files that did not change.
   0001-Update-access-and-modifi... (1 KiB)
Comment by Allan McRae (Allan) - Tuesday, 04 June 2013, 08:25 GMT
That is wrong. It should be the time of the file in the package tarball.

The easiest way to deal with this is just to extract backup files when the checksum of the file on the filesystem is the same as the one in the package.
Comment by Patrick Steinhardt (pks) - Tuesday, 04 June 2013, 08:26 GMT
Thanks for the hint. I'll rework it then.
Comment by Patrick Steinhardt (pks) - Tuesday, 04 June 2013, 08:52 GMT
Corrected version of the patch, now installing unchanged files anyway.
   0001-Install-unchanged-backup... (1.4 KiB)
Comment by Allan McRae (Allan) - Tuesday, 04 June 2013, 09:02 GMT
Looks fine to me. Are you subscribed to pacman-dev and can send it there for review? Also, can you add "Fixes  FS#35515 " to the commit message.
Comment by Patrick Steinhardt (pks) - Tuesday, 04 June 2013, 09:03 GMT
I am subscribed. Will send it later, thanks.

Loading...