FS#34860 - [notmuch] include contrib/notmuch-deliver

Attached to Project: Community Packages
Opened by Sebastian Schwarz (seschwar) - Saturday, 20 April 2013, 13:55 GMT
Last edited by Daniel Wallace (gtmanfred) - Sunday, 02 June 2013, 23:05 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Daniel Wallace (gtmanfred)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Please include contrib/notmuch-deliver in the package.
It makes it easy to integrate notmuch with an already
existing MDA setup. Also the frontend bower needs the tool:
https://github.com/wangp/bower#requirements
This task depends upon

Closed by  Daniel Wallace (gtmanfred)
Sunday, 02 June 2013, 23:05 GMT
Reason for closing:  Implemented
Additional comments about closing:  0.15.2-4
Comment by Sebastian Schwarz (seschwar) - Saturday, 20 April 2013, 14:37 GMT
Alright, here is a PKGBUILD which includes notmuch-deliver with notmuch-runtime.
The PKGBUILD also seems to have accumulated some cruft over time. It therefore also addresses the following issues:

- Move configure stuff into prepare() function.
- Avoid superfluous copy of "$srcdir/$pkgname-$pkgver" to "$srcdir/$pkgname-runtime-$pkgver". We just build in "$srcdir/$pkgbase-$pkgver" and then install from there.
- Do not build ZSH completion in the first place. Then we don't have to remove it afterwards.
- Do not install /usr/sbin/notmuch. `make install` already places it in /usr/bin. Furthermore the one in /usr/sbin didn't even have executable permissions!
- Correctly install notmuch-mutt manual page without .gz suffix. This prevented it from being automatically compressed by makepkg.
- Remove superfluous curly braces around variables.

I hope I wasn't too overzealous and went against your PKGBUILD coding style. Also might I ask why is the package split into notmuch and notmuch-runtime? They both don't take that much disk space. And usually Arch doesn't seem to split language bindings if they are included in the upstream package. Also I find it confusing that the package notmuch-runtime provides actually the Emacs *frontend* to notmuch and not some backend.

Anyways, thanks for maintaining notmuch in [community]!
   PKGBUILD (3.4 KiB)
Comment by Sebastian Schwarz (seschwar) - Sunday, 12 May 2013, 10:54 GMT
Is there any reason this issue was not taken into account for notmuch-0.15.2-2?
Comment by Daniel Wallace (gtmanfred) - Sunday, 12 May 2013, 11:10 GMT
I split them apart because the majority a large number of users only use the -mutt package, and you need -runtime to get any of the other parts working.

as for why it didn't get added for the update, that would be because I haven't had a chance to actually investigate -deliver stuff because I have been busy moving. And I only rebuilt it for the -> bin todo list
Comment by Sebastian Schwarz (seschwar) - Sunday, 12 May 2013, 20:15 GMT
I just wanted to make sure this report didn't slip through any cracks.

However the change in -2 was unnecessary and in fact even harmful as it caused a bug: https://bugs.archlinux.org/task/35221
It was already fixed in my proposed PKGBUILD:

- Do not install /usr/sbin/notmuch. `make install` already places it in /usr/bin. Furthermore the one in /usr/sbin didn't even have executable permissions!

I attached a slightly updated PKGBUILD merging the other changes of -2. The notmuch-deliver stuff is on lines 32-34 and 59, if you want to drop that.
   PKGBUILD (3.4 KiB)
Comment by Sebastian Schwarz (seschwar) - Sunday, 12 May 2013, 21:02 GMT
Also I don't get what you are trying to say about the split. I
think it is good thing that notmuch-mutt is split from the rest.
Otherwise its Perl dependencies would all be optdepends, which
are not as convenient to install.

> only use the -mutt package, and you need -runtime to get any
> of the other parts working.

But notmuch-mutt depends on notmuch-runtime, which includes
everything except the Python and Ruby bindings. So, which
other parts are there that are not installed when installing
notmuch-mutt and wouldn't be working? Merging notmuch and
notmuch-runtime wouldn't increase the size that much.

Anyways, take your time for moving.
Comment by Daniel Wallace (gtmanfred) - Monday, 13 May 2013, 02:54 GMT
configure and autogen.sh do not belong in prepare() only sed commands and patches, stuff that modifies the source, goes in prepare()
Comment by Sebastian Schwarz (seschwar) - Wednesday, 15 May 2013, 14:15 GMT
I see, I have misunderstood prepare(). I thought prepare()
together with build() and install() would be analogous to
./configure, make and make install.

Dropping that misconception the changes to the notmuch PKGBUILD
would be much smaller and therefore I will stop messing with
your PKGBUILD. Though you might want to take a look at the
list of issues of your current PKGBUILD I raised in the first
comment.
Comment by Daniel Wallace (gtmanfred) - Thursday, 23 May 2013, 00:35 GMT
- Do not install /usr/sbin/notmuch. `make install` already places it in /usr/bin. Furthermore the one in /usr/sbin didn't even have executable permissions!
the one that make install installs doesn't come with the executable bit

- Remove superfluous curly braces around variables.
these were to gaurantee that any nearby characters didn't acidentally get added to the variable name
Comment by Sebastian Schwarz (seschwar) - Sunday, 02 June 2013, 15:50 GMT
  • Field changed: Percent Complete (100% → 0%)
There is no 0.15.2-4 in the repos, ABS or even the SVN.

Loading...