FS#34860 - [notmuch] include contrib/notmuch-deliver
Attached to Project:
Community Packages
Opened by Sebastian Schwarz (seschwar) - Saturday, 20 April 2013, 13:55 GMT
Last edited by Daniel Wallace (gtmanfred) - Sunday, 02 June 2013, 23:05 GMT
Opened by Sebastian Schwarz (seschwar) - Saturday, 20 April 2013, 13:55 GMT
Last edited by Daniel Wallace (gtmanfred) - Sunday, 02 June 2013, 23:05 GMT
|
Details
Please include contrib/notmuch-deliver in the package.
It makes it easy to integrate notmuch with an already existing MDA setup. Also the frontend bower needs the tool: https://github.com/wangp/bower#requirements |
This task depends upon
Closed by Daniel Wallace (gtmanfred)
Sunday, 02 June 2013, 23:05 GMT
Reason for closing: Implemented
Additional comments about closing: 0.15.2-4
Sunday, 02 June 2013, 23:05 GMT
Reason for closing: Implemented
Additional comments about closing: 0.15.2-4
The PKGBUILD also seems to have accumulated some cruft over time. It therefore also addresses the following issues:
- Move configure stuff into prepare() function.
- Avoid superfluous copy of "$srcdir/$pkgname-$pkgver" to "$srcdir/$pkgname-runtime-$pkgver". We just build in "$srcdir/$pkgbase-$pkgver" and then install from there.
- Do not build ZSH completion in the first place. Then we don't have to remove it afterwards.
- Do not install /usr/sbin/notmuch. `make install` already places it in /usr/bin. Furthermore the one in /usr/sbin didn't even have executable permissions!
- Correctly install notmuch-mutt manual page without .gz suffix. This prevented it from being automatically compressed by makepkg.
- Remove superfluous curly braces around variables.
I hope I wasn't too overzealous and went against your PKGBUILD coding style. Also might I ask why is the package split into notmuch and notmuch-runtime? They both don't take that much disk space. And usually Arch doesn't seem to split language bindings if they are included in the upstream package. Also I find it confusing that the package notmuch-runtime provides actually the Emacs *frontend* to notmuch and not some backend.
Anyways, thanks for maintaining notmuch in [community]!
as for why it didn't get added for the update, that would be because I haven't had a chance to actually investigate -deliver stuff because I have been busy moving. And I only rebuilt it for the -> bin todo list
However the change in -2 was unnecessary and in fact even harmful as it caused a bug: https://bugs.archlinux.org/task/35221
It was already fixed in my proposed PKGBUILD:
- Do not install /usr/sbin/notmuch. `make install` already places it in /usr/bin. Furthermore the one in /usr/sbin didn't even have executable permissions!
I attached a slightly updated PKGBUILD merging the other changes of -2. The notmuch-deliver stuff is on lines 32-34 and 59, if you want to drop that.
think it is good thing that notmuch-mutt is split from the rest.
Otherwise its Perl dependencies would all be optdepends, which
are not as convenient to install.
> only use the -mutt package, and you need -runtime to get any
> of the other parts working.
But notmuch-mutt depends on notmuch-runtime, which includes
everything except the Python and Ruby bindings. So, which
other parts are there that are not installed when installing
notmuch-mutt and wouldn't be working? Merging notmuch and
notmuch-runtime wouldn't increase the size that much.
Anyways, take your time for moving.
together with build() and install() would be analogous to
./configure, make and make install.
Dropping that misconception the changes to the notmuch PKGBUILD
would be much smaller and therefore I will stop messing with
your PKGBUILD. Though you might want to take a look at the
list of issues of your current PKGBUILD I raised in the first
comment.
the one that make install installs doesn't come with the executable bit
- Remove superfluous curly braces around variables.
these were to gaurantee that any nearby characters didn't acidentally get added to the variable name