FS#34781 - [xmms2] [PATCH] add cdda support

Attached to Project: Community Packages
Opened by Johannes Dewender (JonnyJD) - Sunday, 14 April 2013, 15:55 GMT
Last edited by Sergej Pupykin (sergej) - Saturday, 20 April 2013, 07:22 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
The xmms2 package is compiled without cdda support.
cdda support is a available in general, though.

The reason is possibly because the build fails when having libcdio installed.
The problem is that the include cdio/cdda.h is not available:

../src/plugins/cdda/cdda.c:21:23: fatal error: cdio/cdda.h: No such file or directory

This is now at the location cdio/paranoia/cdda.h in the libcdio-paranoia package.
This can just be changed with sed for arch.
I will also report that upstream, though on that end they have to support both locations so the fix will be a bit more difficult.

I attached a patch, which change can also be found at:
https://github.com/JonnyJD/PKGBUILDs/commit/885b30b7cb476e3cd1b07b5d701468edd8645ce6


Additional info:
* package version(s)
xmms2-0.8DR0_o-12
libcdio-paranoia 10.2+0.90-1
libcdio 0.90-2
libdiscid 0.5.0-1
* config and/or log files etc.
   0001-xmms2-add-cdda-support.p... (1.7 KiB)
This task depends upon

Closed by  Sergej Pupykin (sergej)
Saturday, 20 April 2013, 07:22 GMT
Reason for closing:  Implemented
Comment by Johannes Dewender (JonnyJD) - Sunday, 14 April 2013, 16:16 GMT
upstream bug report:
https://bugs.xmms2.org/view.php?id=2566
Comment by Johannes Dewender (JonnyJD) - Sunday, 14 April 2013, 16:20 GMT
A bit of digging in the git repository reveals:
the header was removed from libcdio with the 0.90 release (2012-10-27).
Comment by Johannes Dewender (JonnyJD) - Sunday, 14 April 2013, 17:54 GMT
There seems to be a patch applied to libcdio-paranoia which has this exact side effect (having the file in cdio/paranoia):
https://projects.archlinux.org/svntogit/packages.git/tree/trunk/header-fix.patch?h=packages/libcdio-paranoia

I couldn't see a reason for that, the package maintainer knows why, I guess.
Comment by Johannes Dewender (JonnyJD) - Sunday, 14 April 2013, 18:33 GMT
Nevermind. That patch is correct. It is upstream at https://github.com/rocky/libcdio-paranoia/commit/b2807f3c7a4126b6078d96adbd37c3760b9f41ab, but 1 day after the release, so not actually part of the release.
(see details and additional links in the xmms2 upstream report.)

I'd say that is unfortunate, but not our problem currently. So my patch for xmms2 should be fine and will work now and in future releases.

Loading...