FS#34645 - [devtools] Creation of root subvolume fails when using btrfs

Attached to Project: Arch Linux
Opened by Evangelos Foutras (foutrelis) - Saturday, 06 April 2013, 20:17 GMT
Last edited by Pierre Schmitz (Pierre) - Sunday, 07 April 2013, 14:07 GMT
Task Type Bug Report
Category Packages: Testing
Status Closed
Assigned To Pierre Schmitz (Pierre)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The resulting error message is:

==> Creating clean working copy [foutrelis]...ERROR: '/var/lib/archbuild/extra-i686/root' is not a subvolume

The above is caused by extra-i686/root not being a subvolume.

According to heftig on IRC, "btrfs can't create the subvol if the dir already exists"; this is why the 'btrfs subvolume create' call in mkarchroot is unsuccessful.

Relevant commit is: https://projects.archlinux.org/devtools.git/commit/?id=1f0374d

Additional info:
* package version(s): devtools 20130406-1
* config and/or log files etc: /var/lib/archbuild is a btrfs filesystem


Steps to reproduce:

Try to build a package using archbuild and friends.
This task depends upon

Closed by  Pierre Schmitz (Pierre)
Sunday, 07 April 2013, 14:07 GMT
Reason for closing:  Fixed
Comment by Jan Alexander Steffens (heftig) - Saturday, 06 April 2013, 20:32 GMT
Trying to properly handle all the possible cases of chroot-on-btrfs-or-not with and without subvolume just gets too complex.

Honestly I would like to throw out the FORCE option and just mandate that the chroot to create doesn't exist already.

Alternatively, maybe FORCE would cause mkarchroot to try and delete the old chroot.
Comment by Jan Alexander Steffens (heftig) - Saturday, 06 April 2013, 20:55 GMT
Proposal: http://sprunge.us/bZYf?diff
Comment by Pierre Schmitz (Pierre) - Sunday, 07 April 2013, 14:07 GMT
Agreed, -f should go.

Loading...