Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#34457 - [lockdev] ttylock.h does not compile with gcc 4.7

Attached to Project: Community Packages
Opened by Richard Tollerton (rtollert) - Monday, 25 March 2013, 18:32 GMT
Last edited by Balló György (City-busz) - Friday, 13 December 2013, 16:01 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

aur/ckermit fails to build with this error:

gcc -O -DLINUX -pipe -funsigned-char -DFNFLOAT -DCK_POSIX_SIG -DCK_NEWTERM -DTCPSOCKET -DLINUXFSSTND -DNOCOTFMC -DPOSIX -DUSE_STRERROR -DCK_NCURSES -I/usr/include/ncurses -DHAVE_PTMX -DHAVE_LOCKDEV -DHAVE_OPENPTY -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CRYPT_H -DKTARGET=\"linux\" -c ckufio.c
In file included from ckutio.c:359:0:
/usr/include/ttylock.h:46:1: error: static declaration of ‘ttylock’ follows non-static declaration
/usr/include/ttylock.h:39:5: note: previous declaration of ‘ttylock’ was here
/usr/include/ttylock.h:53:1: error: static declaration of ‘ttyunlock’ follows non-static declaration
/usr/include/ttylock.h:41:5: note: previous declaration of ‘ttyunlock’ was here
/usr/include/ttylock.h:59:1: error: static declaration of ‘ttylocked’ follows non-static declaration
/usr/include/ttylock.h:42:5: note: previous declaration of ‘ttylocked’ was here
/usr/include/ttylock.h:65:1: error: static declaration of ‘ttywait’ follows non-static declaration
/usr/include/ttylock.h:40:5: note: previous declaration of ‘ttywait’ was here
make[2]: *** [ckutio.o] Error 1


This appears to be because the functions are declared as normal functions, but defined static inline.

This patch appears to solve the problem:

diff -ur lockdev-1.0.3.orig/src/ttylock.h lockdev-1.0.3/src/ttylock.h
--- lockdev-1.0.3.orig/src/ttylock.h 2013-03-25 13:19:53.183242967 -0500
+++ lockdev-1.0.3/src/ttylock.h 2013-03-25 13:20:12.733769572 -0500
@@ -36,10 +36,10 @@

/* API of the library */

-int ttylock (char * devname);
-int ttywait (char * devname);
-int ttyunlock (char * devname);
-int ttylocked (char * devname);
+static inline int ttylock (char * devname);
+static inline int ttywait (char * devname);
+static inline int ttyunlock (char * devname);
+static inline int ttylocked (char * devname);

This task depends upon

Closed by  Balló György (City-busz)
Friday, 13 December 2013, 16:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  lockdev 1.0.3_1.5-4
Comment by Lukas Fleischer (lfleischer) - Tuesday, 18 June 2013, 09:21 GMT
  • Field changed: Category (Packages → Upstream Bugs)
Did you report this upstream?

Loading...