FS#34314 - [pacman] remove no-op from *.proto and from man pages
Attached to Project:
Pacman
Opened by John (graysky) - Thursday, 14 March 2013, 20:54 GMT
Last edited by Allan McRae (Allan) - Monday, 14 October 2013, 05:54 GMT
Opened by John (graysky) - Thursday, 14 March 2013, 20:54 GMT
Last edited by Allan McRae (Allan) - Monday, 14 October 2013, 05:54 GMT
|
Details
In a personal email with Dave R., he pointed out to me that
many of my AUR PKGBUILDs contain a no-op in their functions:
cd "$srcdir" as the first statement. After inspecting
/usr/bin/makepkg, he is right. I took my lead from the wiki
and from the proto files pacman provides under
/usr/share/pacman/*.proto
These should be removed from the proto files and from the wiki: https://wiki.archlinux.org/index.php/Arch_Packaging_Standards I also find this reference in the PKGBUILD man page which should be changed as well. I will post to the discussion page on the wiki with this flyspray. As an FYI, I wrote a little script that uses the ABS tree to see just how many PKGBUILDs also use this: As of 10-Mar-2013: Core: 143/178 fail (80 %) Extra: 925/1982 fail (47 %) Community: 1239/2531 fail (49 %) "fail" = contain the $srcdir no-op. |
This task depends upon
Closed by Allan McRae (Allan)
Monday, 14 October 2013, 05:54 GMT
Reason for closing: Implemented
Additional comments about closing: Mostly fixed in 5f80d7af. Fixing the rest now...
Monday, 14 October 2013, 05:54 GMT
Reason for closing: Implemented
Additional comments about closing: Mostly fixed in 5f80d7af. Fixing the rest now...
cd "$srcdir/$pkgname-$pkgver"
So that is not an no-op... Also, I do no think we have ever documented that you start in $srcdir (in fact, I wonder when that changed from $startdir... - I guess pacman-4.0), so removing that is probably not the best idea...