Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#34184 - [firewalld] Missing dependencies, missing backups

Attached to Project: Community Packages
Opened by Balló György (City-busz) - Wednesday, 06 March 2013, 22:00 GMT
Last edited by Maxime Gauduin (Alucryd) - Wednesday, 06 March 2013, 23:54 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Maxime Gauduin (Alucryd)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I found the following problems with the package (see the attached diff file):

- The etc/conf.d/firewalld and etc/firewalld/firewalld.conf files need to be backed up, otherwise they will be overwritten on every update, which is not the expected behaviour.

- libnotify and networkmanager are required by firewall-applet. Without these packages, it fails to run.

- You don't need to fix file permissions in every package. Fix them only if they are wrong.

- You don't need to call update-desktop-database if the desktop files are not contain MIME types. In this case, you can remove desktop-file-utils dependency.

- Just a suggestion: usually it's better to fix python shebang lines with a command like below instead of a patch, because you don't need to recheck for new python files and fix the patch in every new release:
find . -type f | xargs sed -i 's@^#!.*python$@#!/usr/bin/python2@'
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Wednesday, 06 March 2013, 23:54 GMT
Reason for closing:  Fixed
Comment by Maxime Gauduin (Alucryd) - Wednesday, 06 March 2013, 23:53 GMT
Thank you for the diff Györgi. I've never used the applet and namcap didn't complain since binaries are python scripts. Thx for the backup (never used it before) and suggestion, I've modified it a bit and removed the python2 patch. As for the permissions, they were wrong in earlier revisions, I didn't check if they had corrected them.
I've updated the package in [community], closing the bug then. Thx again.

Loading...