FS#34167 - [gsmartcontrol] Various fixes

Attached to Project: Community Packages
Opened by Balló György (City-busz) - Wednesday, 06 March 2013, 07:17 GMT
Last edited by Jelle van der Waa (jelly) - Wednesday, 13 March 2013, 21:22 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I would like to propose the following changes in gsmartcontrol packaging (see the attachment):

- Use --disable-internal-agent option on pkexec to avoid X freeze in case of no graphical authentication agent available.

- Install desktop and policy files with permission 644 as they are not executables.

- Replace polkit with polkit-gnome in opdepends, since polkit is not enough to launch gsmartcontrol from menu.

- Add hicolor-icon-theme dependency for icons.

- Remove libglademm dependency, as it's not required for gsmartcontrol.

- pcre and glib2 are already satisfied by other dependencies.
   gsmartcontrol.diff (2.3 KiB)
This task depends upon

Closed by  Jelle van der Waa (jelly)
Wednesday, 13 March 2013, 21:22 GMT
Reason for closing:  Implemented
Additional comments about closing:  Changes applied, thanks!
Comment by Jorge Barroso (jorge_barroso) - Wednesday, 06 March 2013, 07:37 GMT
you just changed 'depends' on PKGBUILD and 'exec'on .desktop file, isn't it
Comment by Balló György (City-busz) - Sunday, 10 March 2013, 05:54 GMT
We need to add a wrapper script because launching pkexec directly from a .desktop file doesn't work in many desktop environments and file managers. Here are the results:
https://bugs.archlinux.org/task/34166#comment106918

I attached an updated diff file, which adds a wrapper script.
   gsmartcontrol.diff (4.2 KiB)

Loading...