FS#34120 - [clementine] add chromaprint to dependencies

Attached to Project: Community Packages
Opened by Götz (goetzc) - Saturday, 02 March 2013, 21:40 GMT
Last edited by Stéphane Gaudreault (stephane) - Monday, 25 March 2013, 16:01 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Stéphane Gaudreault (stephane)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
As it can be seen here, chromaprint is needed.
https://code.google.com/p/clementine-player/source/browse/CMakeLists.txt?name=release-1.1#385

Additional info:
* clementine 1.1.1-6
This task depends upon

Closed by  Stéphane Gaudreault (stephane)
Monday, 25 March 2013, 16:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in svn trunk.
Comment by Stéphane Gaudreault (stephane) - Friday, 15 March 2013, 11:33 GMT
The clementine source code contain an internal version of chromaprint in 3rdparty/chromaprint. Is there an advantage of using an external version ?
Comment by Götz (goetzc) - Saturday, 16 March 2013, 03:32 GMT
The internal version is not up to date[1]. Why not have it as dependency, as the other shared libraries, like taglib or the other libs?

[1] https://code.google.com/p/clementine-player/source/browse/?name=release-1.1#git%2F3rdparty%2Fchromaprint
Comment by Stéphane Gaudreault (stephane) - Saturday, 16 March 2013, 13:12 GMT
I have nothing against adding the lib as a dependency, I just need arguments.

You said the internal version is not up to date. Is there any feathure available in the shared lib that is not in the internal one ?
Comment by Götz (goetzc) - Saturday, 16 March 2013, 16:00 GMT
I don't know, I suppose bug fixes and maybe some features. A shared lib has also the intrinsic advantage of using less space on RAM and disk, as it can be shared between others programs.

Loading...