FS#34075 - [archiso] improvements

Attached to Project: Release Engineering
Opened by Matthias Dienstbier (fs4000) - Thursday, 28 February 2013, 14:30 GMT
Last edited by Gerardo Exequiel Pozzi (djgera) - Wednesday, 06 March 2013, 16:11 GMT
Task Type Bug Report
Category ArchISO
Status Closed
Assigned To Gerardo Exequiel Pozzi (djgera)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The find command in mkarchiso:271 will never do anything. The expressions must get separated by -o like so:

find "${work_dir}" -name "*.pacnew" -o -name "*.pacsave" -o -name "*.pacorig" -delete

A dhcpcd.service for all interfaces is now provided by the package. The one provided by archiso should probably be deleted.

https://projects.archlinux.org/archiso.git/tree/configs/releng/root-image/etc/systemd/system/dhcpcd.service
https://projects.archlinux.org/svntogit/packages.git/tree/trunk/dhcpcd.service?h=packages/dhcpcd

The only differences are -A which disables ARP and -k which will release the DHCP release before exit. see  FS#31543 
This task depends upon

Closed by  Gerardo Exequiel Pozzi (djgera)
Wednesday, 06 March 2013, 16:11 GMT
Reason for closing:  Fixed
Comment by Dave Reisner (falconindy) - Thursday, 28 February 2013, 14:45 GMT
Your find command is still wrong. It needs explicit grouping:

find '(' -name foo -o -name bar -o -name baz ')' -delete
Comment by Gerardo Exequiel Pozzi (djgera) - Thursday, 28 February 2013, 21:20 GMT
  • Field changed: Attached to Project (Arch Linux → Release Engineering)
  • Field changed: Status (Unconfirmed → Assigned)
  • Task assigned to Gerardo Exequiel Pozzi (djgera)
Please provide things in a patch form. Thanks!
Comment by Gerardo Exequiel Pozzi (djgera) - Sunday, 03 March 2013, 21:29 GMT
Fixed find command. And using provided dhcpcd.service from dhcpcd pkg looks like fine.

Loading...