FS#33922 - [ettercap-gtk] Broken dependencies (also broken .desktop file)

Attached to Project: Community Packages
Opened by Kevin Dodd (Jesin) - Tuesday, 19 February 2013, 03:58 GMT
Last edited by Jelle van der Waa (jelly) - Sunday, 28 April 2013, 19:11 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
In the PKGBUILD for 0.7.5.3-2, the 'depends' array was first initialized inside the function package_ettercap, rather than at the top level of the PKGBUILD. Because of this, package_ettercap-gtk appends ('gtk2') to an initially-empty 'depends' array, so the resulting ettercap-gtk package does not report any dependencies besides 'gtk2'.

Additionally, the '.desktop' file in the abs tree for 0.7.5.3-2 has a broken "Exec=" line (the .desktop file provided upstream also has this problem), and on top of this it never actually gets installed even in the '-gtk' package, and neither does the corresponding icon.

The attached source package fixes both of these issues.
This task depends upon

Closed by  Jelle van der Waa (jelly)
Sunday, 28 April 2013, 19:11 GMT
Reason for closing:  Implemented
Additional comments about closing:  pkexec implemented
Comment by Kevin Dodd (Jesin) - Tuesday, 19 February 2013, 04:52 GMT
According to namcap, ettercap requires curl but not libltdl (except in makedepends), and I put the icon in the wrong place in my previous upload.

Here's a source package with those issues fixed as well.
Comment by Philip (nuc) - Thursday, 14 March 2013, 22:16 GMT
Did you look into latest upstream development on GitHub? There is a fix for the .desktop file on its way: https://github.com/Ettercap/ettercap/pull/49
Comment by Jelle van der Waa (jelly) - Saturday, 06 April 2013, 19:18 GMT
Deps fixed, upstream pull request should use pkexec and I tried to get it working for ettercap, but it doesn't work atm.

Loading...