Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#33556 - [libcdio-paranoia] unnecessary patches ?

Attached to Project: Arch Linux
Opened by Nuno Araujo (nuno) - Friday, 25 January 2013, 11:11 GMT
Last edited by Jan de Groot (JGC) - Friday, 25 January 2013, 13:46 GMT
Task Type Support Request
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

libcdio-paranoia is patched (header-fix.patch) so its header files are installed in /usr/include/cdio/paranoia/ instead of the default /usr/include/cdio/
This doesn't seems to be necessary since there are no overlapping files with libcdio.

This forces several packages to be patched to adapt to this change:
- community/gmerlin
- community/mplayer2
- community/qmmp
- community/mythplugins
- community/consonance
- community/pragha
- community/mplayer-vaapi
- extra/mplayer
- extra/gvfs
- extra/audacious-plugins

Furthermore, if someone wants to build software who depends on libcdio-paranoia, thee manually need to change the source code to fix the include path.

Was there a reason why this package needed to be patched? I did search a bit on the archlinux MLs but didn't found anything about it.

Additional info:
* libcdio-paranoia 10.2+0.90
This task depends upon

Closed by  Jan de Groot (JGC)
Friday, 25 January 2013, 13:46 GMT
Reason for closing:  Not a bug
Comment by Gustavo Alvarez (sl1pkn07) - Friday, 25 January 2013, 11:47 GMT
mplayer2 from git include this patch in upstream

http://git.mplayer2.org/mplayer2/commit/?id=c5dc8dfe23c58c2a3d554c660c33b40f94ee2db6

edit: mainstream? /me autoslaps
Alzheimer strike back!
Comment by Nuno Araujo (nuno) - Friday, 25 January 2013, 13:28 GMT
Yeah, but that patch doesn't apply to a clean (unpatched) installation of libcdio-cdparanoia-10.2+0.90
The developer probably has manually installed it from git or something.
CDIO_API_VERSION 6 was introduced before the release of libcdio-0.90 while the header files of libcdio-cdparanoia-10.2+0.90 were moved to include/cdio/cdparanoia after the release of libcdio-cdparanoia-10.2+0.90
Comment by Jan de Groot (JGC) - Friday, 25 January 2013, 13:44 GMT
This patch is included upstream:
https://github.com/rocky/libcdio-paranoia/commit/b2807f3c7a4126b6078d96adbd37c3760b9f41ab

Discussion here:
http://lists.gnu.org/archive/html/libcdio-devel/2012-10/msg00057.html

So yes, this patch is needed and software should look in the location where we put it. The location as released in the vanilla tarball is broken.
Comment by Gustavo Alvarez (sl1pkn07) - Friday, 25 January 2013, 13:45 GMT
@nuno

yes. mplayer2 from git don't build with libcdio-paranoia[extra] without header-fix.patch

greetings

Loading...