FS#32663 - [grub-common] does not build from ABS

Attached to Project: Arch Linux
Opened by WorMzy Tykashi (WorMzy) - Thursday, 15 November 2012, 01:18 GMT
Last edited by Tobias Powalowski (tpowa) - Tuesday, 21 May 2013, 12:36 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Ronald van Haren (pressh)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
As with several other packages (which are fixed in svn), this one has a gets declaration which causes compilation to fail. The usual solution works fine:

sed -i -e '/gets is a/d' grub-core/gnulib/stdio.in.h

Placed in both _build_grub-common_and_bios() and build() allows the package to build successfully.

Incidentally, I don't see the purpose of the echo statements. Package builds fine without them.

Additional info:
Package version: grub-{common,bios,efi-1386}-2.00-1.


Steps to reproduce:
Download PKGBUILD, run makepkg.
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Tuesday, 21 May 2013, 12:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  2.00-2
Comment by Dave Reisner (falconindy) - Thursday, 15 November 2012, 01:57 GMT
The usual solution is to report these things upstream. Have you checked for a pre-existing bug and filed one if it doesn't exist?
Comment by WorMzy Tykashi (WorMzy) - Thursday, 15 November 2012, 02:33 GMT
I hadn't. Now I have, and there isn't, as far as I can tell. So I'll make one.

In an attempt to justify my choice of wording, I was referring to these:

[0] https://projects.archlinux.org/svntogit/packages.git/commit/trunk/PKGBUILD?h=packages/diffutils&id=37c7325ee60e28aa51213dd4d491268216ce4185
[1] https://projects.archlinux.org/svntogit/packages.git/commit/trunk/PKGBUILD?h=packages/gettext&id=7c9cb8d8e6471f2e20e9cc06dcf2a29973518bc0
[2] https://bbs.archlinux.org/viewtopic.php?pid=1168546#p1168546

But you are right, these should be addressed upstream.
Comment by WorMzy Tykashi (WorMzy) - Thursday, 15 November 2012, 03:04 GMT
Upstream bug report: https://savannah.gnu.org/bugs/index.php?37738
Comment by Allan McRae (Allan) - Thursday, 15 November 2012, 03:09 GMT
  • Field changed: Summary ([grub-common] gets is a security hole → [grub-common] does not build from ABS)
Changed title... definitely not a security issue.
Comment by Keshav Amburay (the.ridikulus.rat) - Sunday, 17 February 2013, 16:19 GMT
This bug has been fixed in upstream bzr repo, patch at http://bzr.savannah.gnu.org/lh/grub/trunk/grub/revision/4611 .

Loading...