Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#32409 - [polipo] systemd unit should not use Type=oneshot

Attached to Project: Community Packages
Opened by Mantas Mikulėnas (grawity) - Friday, 02 November 2012, 21:50 GMT
Last edited by Thorsten Töpper (Atsutane) - Thursday, 15 November 2012, 19:49 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Thorsten Töpper (Atsutane)
Jelle van der Waa (jelly)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I'm not sure what the polipo.service change [1] in 1.0.4.1-7 was supposed to "fix", but using Type=oneshot for a persistent daemon is just WRONG. The unit should say either

[Service]
ExecStart=/usr/bin/polipo logFile=/var/log/polipo.log
User=nobody

or

[Service]
Type=forking
ExecStart=/usr/bin/polipo daemonise=true logFile=/var/log/polipo.log
User=nobody

(whichever works better) *without* oneshot and *without* RemainAfterExit.

[1]: https://projects.archlinux.org/svntogit/community.git/commit/trunk?h=packages/polipo&id=5d38cc06b9a3182e877b0a08e07630625f61bda6
This task depends upon

Closed by  Thorsten Töpper (Atsutane)
Thursday, 15 November 2012, 19:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in polipo 1.0.4.1-8.
Comment by Thorsten Töpper (Atsutane) - Saturday, 03 November 2012, 16:18 GMT
Well this fix happened after I switched from the initscripts to systemd at one of my systems and used that service file myself. I'm still not really familiar with the service files and the lines you complain about are from this Fedora package: http://koji.fedoraproject.org/koji/buildinfo?buildID=328302 and with the current package they still keep it so: http://koji.fedoraproject.org/koji/buildinfo?buildID=340145

As the systemctl commands start/restart/stop all work fine and I have great respect for the people from the fedora project, what's wrong with that? It would not hurt to forward your explanation and get a result from that conversation which can be handed in upstream.
Comment by Tarqi Kazan (Tarqi) - Friday, 09 November 2012, 01:02 GMT
The reason would be that systemd could track the state of the daemon much better und the status systemd will report is correct. The method you provide leaves polipo as "exited", regardless of its state.

Also see  FS#32553  please. Thanks.
Comment by Alexander F. Rødseth (xyproto) - Sunday, 11 November 2012, 19:10 GMT
New duplicate:  FS#32409 

Loading...