FS#32341 - [tightvnc] Add systemd service file (attached)

Attached to Project: Community Packages
Opened by John (graysky) - Wednesday, 31 October 2012, 22:16 GMT
Last edited by Alexander F. Rødseth (xyproto) - Sunday, 04 November 2012, 00:35 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Alexander F. Rødseth (xyproto)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Package should provide an example service file.
   vncserver@:1.service (0.7 KiB)
This task depends upon

Closed by  Alexander F. Rødseth (xyproto)
Sunday, 04 November 2012, 00:35 GMT
Reason for closing:  Fixed
Comment by Greg (dolby) - Wednesday, 31 October 2012, 23:24 GMT
Sorry meant  FS#32340  This is 32341..
Comment by John (graysky) - Thursday, 01 November 2012, 18:54 GMT
I don't think this is actually a duplicate since tigervnc and tightvnc are two different packages...
Comment by Greg (dolby) - Thursday, 01 November 2012, 19:00 GMT
Oops sorry. It seems quite common for some reason for some users to make consequent duplicate reports. Thought it was one of those.
Comment by John (graysky) - Thursday, 01 November 2012, 22:28 GMT
Actually, I had a typo in my original example. The attached one does not and is more verbose (taken from fedora 18 package btw).
   vncserver.service (1.6 KiB)
Comment by Dave Reisner (falconindy) - Thursday, 01 November 2012, 23:15 GMT
Do not use 'su' in unit files. User= exists for a reason.
Comment by John (graysky) - Friday, 02 November 2012, 19:23 GMT
@Dave - Can you post a patch to the file I included? Also, you might want to post to and repoen https://bugs.archlinux.org/task/32340 since Sergej already implemented and pushed it. As an aside, if your syntax is "more correct" than the supplied file, you might wanna open a task against the fedora package since I lifted mine from them.

http://koji.fedoraproject.org/koji/buildinfo?buildID=352682
Comment by John (graysky) - Saturday, 03 November 2012, 06:20 GMT
@Dave - Plz review the attached and comment.

EDIT - Crap, I can't delete attachments. Use the 2nd one!
   vncserver.service (0.8 KiB)
   vncserver.service (0.8 KiB)
Comment by Dave Reisner (falconindy) - Saturday, 03 November 2012, 12:30 GMT
Looks fine other than the execstartpre hack.
Comment by John (graysky) - Saturday, 03 November 2012, 12:31 GMT
Suggestions for the 'execstartpre hack' or good as-is?
Comment by Dave Reisner (falconindy) - Saturday, 03 November 2012, 12:42 GMT
Get rid of it? If it's desperately needed...

ExecStartPre=-/usr/bin/vncserver -kill %i

This ignores errors and doesn't needlessly fork extra processes.
Comment by John (graysky) - Saturday, 03 November 2012, 13:38 GMT
Thanks, Dave.

@Alexander Rødseth - I think that the attached version is the one for you to include.
@Dave - Can you reopen flyspray #32340 so I can add this version to the package or should it be a new ticket?
   vncserver.service (0.8 KiB)
Comment by Dave Reisner (falconindy) - Saturday, 03 November 2012, 13:52 GMT
Ok, but WHY do you need the hack? It seems totally useless.

If you want a bug reopened, then request that it be reopened...
Comment by John (graysky) - Saturday, 03 November 2012, 13:57 GMT
I am only mirroring the fedora service file. See it in their rpm: http://koji.fedoraproject.org/koji/buildinfo?buildID=352682
I did request it to be reopened but figured since you were so close to this issue you may expedite things.
Comment by Dave Reisner (falconindy) - Saturday, 03 November 2012, 14:25 GMT
Copying things without understanding them is a poor way to do things.

I see no re-open request for  FS#32340 , but I've reopened it anyways.
Comment by Alexander F. Rødseth (xyproto) - Sunday, 04 November 2012, 00:35 GMT
Thanks for all the comments. Added the .service file and added John to the list of contributors. Also added a .desktop file for the viewer and made a minor change to make it compile again.
I was in doubt if the ExecStartPre line should be included or not, but it seems very handy when running vnc on a computer without direct/local access, so it is included.
The fixed version will appear in [community] shortly.

Loading...