FS#32146 - [xorg-server-devel] Missing dependency on resourceproto

Attached to Project: Arch Linux
Opened by Emil (xexaxo) - Sunday, 21 October 2012, 16:37 GMT
Last edited by Jan de Groot (JGC) - Thursday, 08 November 2012, 20:51 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Andreas Radke (AndyRTR)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:

While trying to build my custom xf86-video-nouveau package I've noticed that as of 1.13.0 the xorg-server-devel package introduced a dependency on resourceproto (X11/extensions/XResproto.h)

In file included from /usr/include/xorg/globals.h:8:0,
from /usr/include/xorg/opaque.h:34,
from /usr/include/xorg/xf86_OSproc.h:127,
from nv_include.h:16,
from nouveau_exa.c:23:
/usr/include/xorg/extinit.h:107:38: fatal error: X11/extensions/XResproto.h: No such file or directory

Appreciated

Additional info:
* package version(s)
Present in xorg-server-devel - 1.13.0-2 and 1.13.0-3 (possibly earlier as well)

Steps to reproduce:
* Try to build anything that depends on xorg/xf86_OSproc.h, xorg/opaque.h or xorg/globals.h (all of those are provided by xorg-server-devel)
This task depends upon

Closed by  Jan de Groot (JGC)
Thursday, 08 November 2012, 20:51 GMT
Reason for closing:  Fixed
Additional comments about closing:  Added dependencies to PKGBUILD with reference to this bug. Let's see when upstream points out you're right about this.
Comment by Andreas Radke (AndyRTR) - Sunday, 21 October 2012, 18:12 GMT
grep Requires /usr/lib/pkgconfig/xorg-server.pc
Requires.private: xproto >= 7.0.22 randrproto >= 1.4.0 renderproto >= 0.11 xextproto >= 7.1.99 inputproto >= 2.1.99.6 kbproto >= 1.0.3 fontsproto pixman-1 >= 0.21.8 videoproto xf86driproto >= 2.1.0 glproto >= 1.4.16 dri >= 7.8.0 dri2proto >= 2.8 xineramaproto pciaccess >= 0.12.901

It seems upstream devs missed to add it or don't want it there. So far we have added 'resourceproto' and 'scrnsaverproto' to all our driver packages.

I'm not sure if the extensions dependencies should be put into the xorg-server-del pkg.

[root@laptop64 andyrtr]# grep XResproto.h /usr/include/xorg/*
/usr/include/xorg/extinit.h:#include <X11/extensions/XResproto.h>
[root@laptop64 andyrtr]# pacman -Qo /usr/include/xorg/extinit.h
/usr/include/xorg/extinit.h ist in xorg-server-devel 1.13.0-3 enthalten

[root@laptop64 andyrtr]# grep saver.h /usr/include/xorg/*
/usr/include/xorg/extinit.h:#include <X11/extensions/saver.h>

I vote for keep adding deps to the drivers packages.
Comment by Emil (xexaxo) - Sunday, 21 October 2012, 18:51 GMT
I personally would solve this issue once in the correct place. There are currently more than 70 xf86-video-* packages
Comment by Emil (xexaxo) - Sunday, 21 October 2012, 19:33 GMT
Just sent a patch to xorg-devel correcting the configure.ac script. If it's merged it will ensure xorg-server.pc states the correct Requires.private

Update: One year later the patch was merged http://cgit.freedesktop.org/xorg/xserver/commit/?id=ea3b7db4b747f883ef7b8b524ee13bf8a63add14

Loading...