FS#31413 - [atop] broken rc.d script

Attached to Project: Community Packages
Opened by Krzysztof Warzecha (hiciu) - Tuesday, 04 September 2012, 21:08 GMT
Last edited by Sergej Pupykin (sergej) - Wednesday, 05 September 2012, 14:37 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Atop provides rc.d script, cron job and logrotate script that starts process accounting and rotate logs. Package contents look like this:

atop /etc/
atop /etc/atop/
atop /etc/cron.d/
atop /etc/cron.daily/
atop /etc/cron.daily/atop
atop /etc/logrotate.d/
atop /etc/logrotate.d/psaccs_atop
atop /etc/logrotate.d/psaccu_atop
atop /etc/rc.d/
atop /etc/rc.d/atop
atop /usr/
atop /usr/bin/
atop /usr/bin/atop
atop /usr/bin/atop-1.27-3
atop /usr/bin/atopsar
atop /usr/bin/atopsar-1.27-3
atop /usr/share/
atop /usr/share/man/
atop /usr/share/man/man1/
atop /usr/share/man/man1/atop.1.gz
atop /usr/share/man/man1/atopsar.1.gz
atop /usr/share/man/man5/
atop /usr/share/man/man5/atoprc.5.gz
atop /var/
atop /var/log/
atop /var/log/atop/
atop /var/log/atop/dummy_after
atop /var/log/atop/dummy_before


/etc/rc.d/atop is broken, it tries to run /etc/atop/atop.daily (nonexisting) file.

$ grep atop.daily /etc/rc.d/atop
/etc/atop/atop.daily
/etc/atop/atop.daily
/etc/atop/atop.daily

I belive it should run /etc/cron.daily/atop. We could provide symlink /etc/atop/atop.daily -> ../cron.daily/atop or change script (symlink works fine).


atop package also provides logrotate scripts:

atop /etc/logrotate.d/
atop /etc/logrotate.d/psaccs_atop
atop /etc/logrotate.d/psaccu_atop

But I am pretty sure they will not work under archlinux (we have no psacct service; GNU Accounting Utilities are in aur as `acct`, but they do not provide /etc/logrotate.d/psacct file needed by logrotate scripts).

Additional info:

Name : atop
Version : 1.27_3-2
URL : http://www.atoptool.nl/
Licenses : GPL
Groups : None
Provides : None
Depends On : ncurses sh zlib
Optional Deps : None
Required By : None
Conflicts With : None
Replaces : None
Installed Size : 404.00 KiB
Packager : Sergej Pupykin <pupykin.s+arch@gmail.com>
Architecture : x86_64
Build Date : Mon Aug 27 10:45:57 2012
Install Date : Tue Sep 4 15:17:51 2012
Install Reason : Explicitly installed
Install Script : No
Description : A system and process level monitor.

Steps to reproduce:

1. pacman -S atop
2. rc.d start atop
This task depends upon

Closed by  Sergej Pupykin (sergej)
Wednesday, 05 September 2012, 14:37 GMT
Reason for closing:  Fixed

Loading...