FS#31289 - [dhclient] relies heavily on deprecated net-tools, needs fixing

Attached to Project: Arch Linux
Opened by Thomas Bächler (brain0) - Sunday, 26 August 2012, 14:04 GMT
Last edited by Jan de Groot (JGC) - Tuesday, 19 March 2013, 15:21 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Ronald van Haren (pressh)
Isenmann Daniel (ise)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 6
Private No

Details

Our current dhclient-script relies heavily on ifconfig and route. It also relies on ip for ipv6, thus mixing old and new tools.

It is based on a script that was written in 1999, by a guy who was a complete shell scripting and linux noob, and is apparently completely unmaintained.

Fedora has its own version of the script ([1]), but that uses tools we don't have - it is still a much better start than what upstream dhclient provides.

Both scripts have a /bin/bash shebang, which is also bad, because I wanted to use dhclient+dhclient-script in initramfs, where I don't have bash.

This script needs to be replaced by something that doesn't use deprecated tools and doesn't necessarily rely on bash.

[1] http://pkgs.fedoraproject.org/cgit/dhcp.git/tree/dhclient-script
This task depends upon

Closed by  Jan de Groot (JGC)
Tuesday, 19 March 2013, 15:21 GMT
Reason for closing:  Implemented
Comment by Greg (dolby) - Tuesday, 23 October 2012, 13:15 GMT
Diff with upstream
   diff (5.2 KiB)
Comment by Greg (dolby) - Tuesday, 23 October 2012, 13:22 GMT
Heres Debian's version for reference as well.
http://anonscm.debian.org/gitweb/?p=pkg-dhcp/isc-dhcp.git;a=blob;f=debian/dhclient-script.linux;h=85101554bbfba1f95df2999bd9c197dc045b427e;hb=HEAD
Comment by Greg (dolby) - Tuesday, 23 October 2012, 17:01 GMT
seems like the ipcalc fedora's script is using an app part of its initscripts package, not the one Arch has in community.
Comment by Thomas Bächler (brain0) - Tuesday, 23 October 2012, 22:31 GMT
Correct. I forgot what their ipcalc was used for, but it seemed unnecessary at the time. In general, Fedora's script tries to do way too much.
Comment by Greg (dolby) - Wednesday, 24 October 2012, 13:42 GMT
@brain0: maybe use something like this instead?
http://www.linuxfromscratch.org/patches/downloads/dhcp/dhcp-4.2.4-P2-client-script-1.patch
LFS also has another patch from fedora: http://www.linuxfromscratch.org/patches/downloads/dhcp/dhcp-4.2.4-P2-missing_ipv6-1.patch
The first patch applies on the upstream linux dhclient-script which is almost identical to the one Arch is using.
Comment by Greg (dolby) - Wednesday, 24 October 2012, 18:02 GMT
attached dhclient-script produced by BLFS patch.
   dhclient-script (12 KiB)

Loading...