FS#31277 - [munin] Huge munin-graph log with graph_strategy left unset

Attached to Project: Arch Linux
Opened by Evangelos Foutras (foutrelis) - Saturday, 25 August 2012, 03:15 GMT
Last edited by Evangelos Foutras (foutrelis) - Tuesday, 16 April 2013, 02:39 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

I kept the default munin configuration after 2.0.4 was pushed to [extra], and I noticed that it now produces a huge munin-graph.log file and a bigger than necessary munin-html.log file.

More specifically:

munin-graph.log
---------------

Previously it would log about 36 lines per run; now it's sticking 2642 lines into the log file each time it runs.

For each graph it would output something like this:

2012/08/19 03:15:08 [INFO] Graphed service [host identifier]:uptime (0.11 sec)

But now:

2012/08/25 02:45:22 Request path is /host/path/uptime-year.png
2012/08/25 02:45:22 asked for (host, path, uptime, year)
2012/08/25 02:45:22 Starting munin-graph
2012/08/25 02:45:22 [INFO] Looking into drawing /usr/share/munin/www/host/path/uptime-year.png
2012/08/25 02:45:22 [INFO] Graphed service host;path:uptime (0.03 sec for 1 graphs)
2012/08/25 02:45:22 Munin-graph finished (0.03 sec)
2012/08/25 02:45:22 X-Munin-Request: 240/0
2012/08/25 02:45:22 Content-Length: 19428
2012/08/25 02:45:22 Last-Modified: Sat, 25 Aug 2012 02:45:22 GMT
2012/08/25 02:45:22 Expires: Sun, 26 Aug 2012 00:00:00 GMT

(the above repeats 7 more times; for uptime-month.png, uptime-week.png, uptime-day.png -- for some reason, along with uptime-year.png, these appear twice in the same run)

The amount of log information generated is about 50MB/day with 33 plugins enabled and a total of 132 generated graph images. Rotated weekly, this goes up to ~350MB. (More plugins enabled would mean even bigger log files.)

munin-html.log
--------------

This one went from storing 4 lines of text per run to about 171. The extra lines repeat the following two warnings:

[PERL WARNING] Use of uninitialized value in string eq at /usr/share/perl5/vendor_perl/Munin/Master/HTMLConfig.pm line 461.
[PERL WARNING] Use of uninitialized value in string eq at /usr/share/perl5/vendor_perl/Munin/Master/HTMLConfig.pm line 488.

Line 461 in that file is -> if ($config->{'graph_strategy'} eq "cgi") {
Line 488 in that file is -> next if ($config->{'graph_strategy'} eq "cgi");

I guess, in both cases, it doesn't appreciate having graph_strategy commented out in munin.conf.

Additional info:
* package version(s): munin{,-node} 2.0.4-1
* config and/or log files etc. -> default munin.conf with one host added


Steps to reproduce:

- Leave html_strategy cgi commented
- Watch /var/log/munin/munin-graph.log grow larger and larger
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Tuesday, 16 April 2013, 02:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  Should be completely fixed in munin 2.0.12-1.
Comment by Dan McGee (toofishes) - Tuesday, 04 September 2012, 13:03 GMT
I believe this is fixed upstream in 2.0.6, which I will be pushing very soon.
Comment by Evangelos Foutras (foutrelis) - Tuesday, 04 September 2012, 14:08 GMT
I just gave 2.0.6 a try, but it doesn't improve the situation:

# wc -l munin-graph.log
1321 munin-graph.log

# wc -l munin-html.log
171 munin-html.log

Those are the line counts from a single run. 1321 is exactly half of the 2642 lines I quote in the report description above, so I might have mistakenly counted two runs in my original report.

Do you think I should file a ticket on Munin's Trac?
Comment by Dan McGee (toofishes) - Tuesday, 04 September 2012, 21:23 GMT
Yeah, it is probably worth filing an issue- this seems way too chatty.
Comment by Evangelos Foutras (foutrelis) - Wednesday, 05 September 2012, 08:50 GMT
Ticket filed upstream is at http://munin-monitoring.org/ticket/1251.
Comment by Dan McGee (toofishes) - Wednesday, 03 October 2012, 14:22 GMT
Fixed in 2.0.7?
Comment by Evangelos Foutras (foutrelis) - Thursday, 04 October 2012, 15:12 GMT
Partially, yes. Instead of 1321, it's now logging 396 lines to munin-graph.log.

I have asked upstream [1] whether it's possible to reduce it further, to 132 (and maybe even 1/4 of that). (No response yet.)

The two warnings that were logged to munin-html.log were fixed upstream, but in 2.0.7 there's a new warning:

"[PERL WARNING] Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/vendor_perl/Munin/Master/HTMLConfig.pm line 502"

I filed a new issue about the new warning: http://www.munin-monitoring.org/ticket/1262

[1] http://munin-monitoring.org/ticket/1251#comment:7

Loading...