Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/index.php/Reporting_Bug_Guidelines

Do NOT report bugs when a package is just outdated, or it is in Unsupported. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#31251 - [rsync] use $RSYNCD_ARGS instead of ${RSYNCD_ARGS} in systemd service file

Attached to Project: Arch Linux
Opened by S├ębastien Luttringer (seblu) - Wednesday, 22 August 2012, 17:36 GMT
Last edited by Pierre Schmitz (Pierre) - Saturday, 02 November 2013, 22:59 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Pierre Schmitz (Pierre)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

We should do the following modification :

-ExecStart=/usr/bin/rsync --daemon --no-detach ${RSYNCD_ARGS}
+ExecStart=/usr/bin/rsync --daemon --no-detach $RSYNCD_ARGS

As explain in man systemd.service,

On top of that basic environment variable substitution is supported. Use ${FOO} as part of a word, or as
word of its own on the command line, in which case it will be replaced by the value of the environment
variable including all whitespace it contains, resulting in a single argument. Use $FOO as a separate
word on the command line, in which case it will be replaced by the value of the environment variable
split up at whitespace, resulting in no or more arguments. Note that the first argument (i.e. the
program to execute) may not be a variable, and must be a literal and absolute path name.


So rsyncd_args should be splited as shell do and not take an uniq option.
This task depends upon

Closed by  Pierre Schmitz (Pierre)
Saturday, 02 November 2013, 22:59 GMT
Reason for closing:  Won't fix
Comment by Dave Reisner (falconindy) - Saturday, 25 August 2012, 18:51 GMT
One better -- we shouldn't be using an EnvironmentFile.

Loading...