Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/index.php/Reporting_Bug_Guidelines

Do NOT report bugs when a package is just outdated, or it is in Unsupported. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#31148 - [tftp-hpa] add systemd unit file

Attached to Project: Arch Linux
Opened by Tomáš Henzl (Henkye) - Thursday, 16 August 2012, 00:16 GMT
Last edited by Thomas Bächler (brain0) - Saturday, 03 November 2012, 19:51 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Please add a systemd unit file. Attached one, just install it to /usr/lib/systemd/system/tftp.service, please. Thanks!
This task depends upon

Closed by  Thomas Bächler (brain0)
Saturday, 03 November 2012, 19:51 GMT
Reason for closing:  Implemented
Comment by Tomáš Henzl (Henkye) - Thursday, 16 August 2012, 01:47 GMT
Mistake, fixed. Ignore first file.
Comment by Thomas Bächler (brain0) - Thursday, 30 August 2012, 12:26 GMT
Yeah, this is still missing.

I'd much rather have a socket-activated method, but I guess we can easily provide both.
Comment by Denis Yantarev (denn) - Tuesday, 30 October 2012, 18:49 GMT
In the current version of the package there is tftpd.service file. Unfortunately it is missing [Install] section. Also relation between tftpd.service and tftpd.socket is unclear. It seems that currently both need be explicitly enabled to allow tftpd startup at system boot...
Comment by Thomas Bächler (brain0) - Tuesday, 30 October 2012, 19:36 GMT
Just enable the socket, that's it. I have some changes locally to make it clearer.
Comment by Denis Yantarev (denn) - Tuesday, 30 October 2012, 19:42 GMT
Why not to add install section and socket dependency to the service file? Something like this:

[Unit]
Description=hpa's original TFTP daemon
Requires=tftpd.socket

[Install]
WantedBy=multi-user.target
Also=tftpd.socket
Comment by Thomas Bächler (brain0) - Tuesday, 30 October 2012, 19:45 GMT
I did that locally but didn't push it out yet. The WantedBy is incorrect by the way.
Comment by Denis Yantarev (denn) - Tuesday, 30 October 2012, 20:00 GMT
What's wrong with WantedBy? It is used this way in all Arch service files I've seen.
Comment by Thomas Bächler (brain0) - Tuesday, 30 October 2012, 20:21 GMT
You are not supposed to activate the .service, only the .socket. Please, read the manpage, they explain it much better than I can.
Comment by Denis Yantarev (denn) - Saturday, 03 November 2012, 19:04 GMT
There is another issue with current tftpd.service. Previously it was possible to specify additional commandline args via TFTPD_ARGS variable in /etc/conf.d/tftpd (which I've used it to specify remap file). tftpd.service doesn't have this capability and the only solution is to clone it to /etc/systemd/system and add args there. Which is not a good thing I believe.
Comment by Dave Reisner (falconindy) - Saturday, 03 November 2012, 19:16 GMT
No, this is exactly the intention. You can use systemd-delta to keep track of drift between the units.
Comment by Thomas Bächler (brain0) - Saturday, 03 November 2012, 19:51 GMT
Copying the service file is the right thing to do.

Loading...