Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#30900 - [slim] session changes after failed login attempt

Attached to Project: Arch Linux
Opened by Raymond Wagenmaker (raynman) - Saturday, 28 July 2012, 22:44 GMT
Last edited by Evangelos Foutras (foutrelis) - Tuesday, 22 January 2013, 10:01 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Roman Kyrylych (Romashka)
Evangelos Foutras (foutrelis)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
When you have multiple sessions in the list in /etc/slim.conf and you mistype your password, you unexpectedly end up in a different session than the default or whatever you had selected before the failed login attempt.

The problem is the first line in Panel::ClearPanel() in panel.cpp. Upstream resets the session to "", Arch has a patch that jumps to the next session. So upstream's version only causes trouble if you selected something other than the default session, the patched version always changes the session.

I would say the most sensible solution is to simply remove this line, so that the selected session is not changed between login attempts. The second option would be to stick to the original behavior, but the patch (from  FS#26693 ) makes this harder, and changing the patch to fix the comment rather than the behavior would probably break existing configurations.

Additional info:
* version: 1.3.4-2
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Tuesday, 22 January 2013, 10:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  Patch has been dropped; slim is now completely vanilla.
Comment by Tobias Powalowski (tpowa) - Wednesday, 08 August 2012, 06:19 GMT
http://developer.berlios.de/bugs/?func=detailbug&bug_id=18606&group_id=2663
Comment by David Chamberlain (dc46and2) - Sunday, 25 November 2012, 02:32 GMT
My solution is attached. I think this preserves the original intent of the author, without breaking existing configurations. After a wrong password, session is reset to default. Maybe annoying if you had just selected something other than default, but it makes things consistent: if no "Session: name" message is displayed, you know the default is selected.
   my-session-name.patch (1.3 KiB)
Comment by Philip (nuc) - Sunday, 25 November 2012, 12:44 GMT
Not the ideal solution but no doubt improves the situation.
Comment by David Chamberlain (dc46and2) - Monday, 26 November 2012, 04:35 GMT
Overlooked an obvious exception in the original patch.
   my-session-name.patch (1.4 KiB)
Comment by Evangelos Foutras (foutrelis) - Saturday, 19 January 2013, 04:38 GMT
I have dropped the existing patch in slim 1.3.5-1 (currently in [testing]) and don't intend to add a new one.

This is something that needs to be fixed upstream:

http://developer.berlios.de/bugs/?func=detailbug&bug_id=17657&group_id=2663

Loading...