FS#30766 - [nodejs] installer.js doesn't always use DESTDIR

Attached to Project: Community Packages
Opened by Mathias Rohnstock (drmonty) - Friday, 20 July 2012, 08:29 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Friday, 20 July 2012, 09:07 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
installer.js doesn't use DESTDIR on removing /lib/node_modules/npm, when it's not a symlink.

Additional info:
* package version(s): 0.8.3-1
* config and/or log files etc.: nothing

Steps to reproduce:
makepkg on already installed nodejs.
installer.js want deleting /usr/lib/node_modules/npm/* not ${pkdir}/lib/node_modules/npm/*.
installer.js can't remove the files, because of missing permissions.

Fix:
add the following PKGBUILD on "package() {" afer "cd node-v${pkgver}":

sed -i "s|var npmDir = path.resolve(node_prefix, 'lib/node_modules/npm');|var npmDir = path.join(dest_dir, node_prefix, 'lib/node_modules/npm');|" tools/installer.js

I think, I should report this upstream, too.
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Friday, 20 July 2012, 09:07 GMT
Reason for closing:  Fixed
Additional comments about closing:  nodejs 0.8.3-2
Comment by Mathias Rohnstock (drmonty) - Friday, 20 July 2012, 08:44 GMT
upstream: https://github.com/joyent/node/pull/3744
Comment by Bartłomiej Piotrowski (Barthalion) - Friday, 20 July 2012, 08:48 GMT
I'm recompiling packages with your fix right now. Thanks for reporting upstream!

Loading...